Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Hard deprecate PageArchive::getPreviousRevision"

Browse source
This commit is contained in:
jenkins-bot 2020-05-07 14:58:42 +00:00 committed by Gerrit Code Review
commit 7a36d66d75
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.35
View file

@ -716,7 +716,7 @@ because of Phabricator reports.
* ApiTestCase::doLogin, soft deprecated in 1.31, was hard deprecated.
* WebRequest::getLimitOffset is hard deprecated. Instead, use
::getLimitOffsetForUser and pass a User object.
* PageArchive::getPreviousRevision is soft deprecated. Instead, use the new
* PageArchive::getPreviousRevision is hard deprecated. Instead, use the new
::getPreviousRevisionRecord method.
* PageArchive::getArchivedRevision is hard deprecated. Instead, use the new
::getArchivedRevisionRecord method.

2
includes/page/PageArchive.php
View file

@ -325,6 +325,8 @@ class PageArchive {
* @return Revision|null Null when there is no previous revision
*/
public function getPreviousRevision( $timestamp ) {
wfDeprecated( __METHOD__, '1.35' );
$revRecord = $this->getPreviousRevisionRecord( $timestamp );
$rev = $revRecord ? new Revision( $revRecord ) : null;
return $rev;

2
tests/phpunit/includes/page/PageArchiveTest.php
View file

@ -343,6 +343,8 @@ class PageArchiveTest extends MediaWikiTestCase {
* @covers PageArchive::getPreviousRevision
*/
public function testGetPreviousRevision() {
$this->hideDeprecated( 'PageArchive::getPreviousRevision' );
$rev = $this->archivedPage->getPreviousRevision( $this->ipRev->getTimestamp() );
$this->assertNotNull( $rev );
$this->assertSame( $this->firstRev->getId(), $rev->getId() );