Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WebRequest: Update comment with a TODO now that HHVM is gone

Browse source 
Change-Id: I444d1be4d7194e1d0c705ac9a4e79c73e69a1c78
This commit is contained in:
James D. Forrester 2019-10-10 12:56:42 -07:00
parent 4771c10b8a
commit 7bcd897dd6
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/WebRequest.php
View file

@ -103,7 +103,10 @@ class WebRequest {
/**
* @var SessionId|null Session ID to use for this
* request. We can't save the session directly due to reference cycles not
* working too well (slow GC in Zend and never collected in HHVM).
* working too well (slow GC).
*
* TODO: Investigate whether this GC slowness concern (added in a73c5b7395 with regard to
* PHP 5.6) still applies in PHP 7.2+.
*/
protected $sessionId = null;