Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

objectcache: Fix HashBagOStuffTest test in PHP 7.1

Browse source 
> There was 1 error:
>
> 1) HashBagOStuffTest::testEvictionAdd
> A non-numeric value encountered
>
> tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php:106

This warning is new in PHP 7.1, however the behaviour is not new.
This code was already not behaving as it should have. Concatenation
preceeds addition/multiplication. As such, this was producing
(int)-10 each time instead of (str)"key0" through (str)"key10".

Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852
This commit is contained in:
Timo Tijhof 2017-12-01 13:28:36 -08:00
parent bd78292e75
commit 7dbc5b0fe6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php
View file

@ -103,7 +103,7 @@ class HashBagOStuffTest extends PHPUnit_Framework_TestCase {
for ( $i = 10; $i < 20; $i++ ) {
$cache->set( "key$i", 1 );
$this->assertEquals( 1, $cache->get( "key$i" ) );
$this->assertEquals( false, $cache->get( "key" . $i - 10 ) );
$this->assertEquals( false, $cache->get( "key" . ( $i - 10 ) ) );
}
}