Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Demote "throttler data not found" logs to info level

Browse source 
Bug: T158364
Change-Id: I049c2d6da4720341ef2a380879ac19aff444b1d0
This commit is contained in:
Gergő Tisza 2017-02-16 16:47:49 -08:00 committed by Gergő Tisza
parent fd5747ea16
commit 7dcefe4468
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/auth/ThrottlePreAuthenticationProvider.php
View file

@ -167,7 +167,9 @@ class ThrottlePreAuthenticationProvider extends AbstractPreAuthenticationProvide
$data = $this->manager->getAuthenticationSessionData( 'LoginThrottle' );
if ( !$data ) {
$this->logger->error( 'throttler data not found for {user}', [ 'user' => $user->getName() ] );
// this can occur when login is happening via AuthenticationRequest::$loginRequest
// so testForAuthentication is skipped
$this->logger->info( 'throttler data not found for {user}', [ 'user' => $user->getName() ] );
return;
}

2
tests/phpunit/includes/auth/ThrottlePreAuthenticationProviderTest.php
View file

@ -226,7 +226,7 @@ class ThrottlePreAuthenticationProviderTest extends \MediaWikiTestCase {
$provider->postAuthentication( \User::newFromName( 'SomeUser' ),
AuthenticationResponse::newPass() );
$this->assertSame( [
[ \Psr\Log\LogLevel::ERROR, 'throttler data not found for {user}' ],
[ \Psr\Log\LogLevel::INFO, 'throttler data not found for {user}' ],
], $logger->getBuffer() );
}
}