Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix switch-case syntax in ParserOutputAccess

Browse source 
The equality check is unnecessary, the switch-case construct
does it. The code should work the same:
When $useCache is equal to CACHE_SECONDARY, the expression
evaluates to true and so does the loose comparison done by
the switch.
Otherwise it evaluates to false and the case is false, too.

Follow-Up: I0fe275b4991f1bf89c7bb587132bc4fb0ea862e2
Change-Id: I2ded074d4e31d5770c02b4d5ac4acc58b8542ad0
This commit is contained in:
Matěj Suchánek 2022-03-14 18:13:35 +01:00 committed by Umherirrender
parent 043733cb84
commit 7f6323e355
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/page/ParserOutputAccess.php
View file

@ -425,7 +425,7 @@ class ParserOutputAccess {
$this->wikiPageFactory
);
case $useCache == self::CACHE_SECONDARY:
case self::CACHE_SECONDARY:
$this->statsDataFactory->increment( 'ParserOutputAccess.PoolWork.Old' );
$workKey = $this->secondaryCache->makeParserOutputKey( $revision, $parserOptions );
return new PoolWorkArticleViewOld(