Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "Title: Throw if newFromText is given an invalid value"

Browse source
This commit is contained in:
jenkins-bot 2016-04-15 22:55:00 +00:00 committed by Gerrit Code Review
commit 82797111cb
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/Title.php
View file

@ -268,13 +268,9 @@ class Title implements LinkTarget {
* @return Title|null Title or null on an error.
*/
public static function newFromText( $text, $defaultNamespace = NS_MAIN ) {
if ( is_object( $text ) ) {
throw new InvalidArgumentException( '$text must be a string.' );
}
// DWIM: Integers can be passed in here when page titles are used as array keys.
if ( $text !== null && !is_string( $text ) && !is_int( $text ) ) {
wfDebugLog( 'T76305', wfGetAllCallers( 5 ) );
return null;
throw new InvalidArgumentException( '$text must be a string.' );
}
if ( $text === null ) {
return null;