Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rdbms: Flip ConnectionManager deprecations to match ILoadBalancer

Browse source 
The difference between non-ref, ref, and lazy connections has been
eliminated; all connections are lazy and reference counted now.
Consequently, deprecate the ref and lazy methods: all callers should
just use getReadConnection() and getWriteConnection() now.

Bug: T312527
Change-Id: I72713a7a1127541fa2d0f45b75373100e3b400fc
This commit is contained in:
Lucas Werkmeister 2022-07-07 13:11:30 +02:00 committed by Krinkle
parent 52bf11384c
commit 8287e2814d
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/libs/rdbms/connectionmanager/ConnectionManager.php
View file

@ -91,29 +91,25 @@ class ConnectionManager {
}
/**
* Returns a connection to the primary DB, for updating. The connection should later be released
* by calling releaseConnection().
* Returns a connection to the primary DB, for updating.
*
* @since 1.29
* @since 1.37 Added optional $flags parameter
* @param int $flags
* @return IDatabase
* @deprecated since 1.38; Use getWriteConnectionRef()
*/
public function getWriteConnection( int $flags = 0 ) {
return $this->getConnection( DB_PRIMARY, null, $flags );
}
/**
* Returns a database connection for reading. The connection should later be released by
* calling releaseConnection().
* Returns a database connection for reading.
*
* @since 1.29
* @since 1.37 Added optional $flags parameter
* @param string[]|null $groups
* @param int $flags
* @return IDatabase
* @deprecated since 1.38; Use getReadConnectionRef()
*/
public function getReadConnection( ?array $groups = null, int $flags = 0 ) {
$groups = $groups ?? $this->groups;
@ -135,6 +131,7 @@ class ConnectionManager {
* @since 1.29
*
* @return DBConnRef
* @deprecated since 1.39; Use getWriteConnection()
*/
public function getWriteConnectionRef() {
return $this->getConnectionRef( DB_PRIMARY );
@ -146,6 +143,7 @@ class ConnectionManager {
* @since 1.29
* @param string[]|null $groups
* @return DBConnRef
* @deprecated since 1.38; Use getReadConnection()
*/
public function getReadConnectionRef( array $groups = null ) {
$groups = $groups ?? $this->groups;
@ -157,6 +155,7 @@ class ConnectionManager {
*
* @since 1.38
* @return DBConnRef
* @deprecated since 1.39; Use getWriteConnection()
*/
public function getLazyWriteConnectionRef(): DBConnRef {
return $this->getConnectionRef( DB_PRIMARY );
@ -168,6 +167,7 @@ class ConnectionManager {
* @since 1.37
* @param string[]|null $groups
* @return DBConnRef
* @deprecated since 1.39; Use getReadConnection()
*/
public function getLazyReadConnectionRef( array $groups = null ) {
$groups = $groups ?? $this->groups;