Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

WebRequest: Use getRawVal instead of getGPCVal where possible

Browse source 
Avoid getGPCVal() for simple methods that only need a boolean,
number or specific string outcome.

This saves overhead of touching $wgContLang or UtfNormal\Validator
and makes load.php initialisation no longer depend on it.

Change-Id: I8ce1fa31f5102b3fa18b0d0b9f56c42cb90146a1
This commit is contained in:
Timo Tijhof 2016-09-09 15:46:08 -07:00
parent 3de9d6721e
commit 83df6d8123
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
includes/WebRequest.php
View file

@ -520,7 +520,7 @@ class WebRequest {
* @return int
*/
public function getInt( $name, $default = 0 ) {
return intval( $this->getVal( $name, $default ) );
return intval( $this->getRawVal( $name, $default ) );
}
/**
@ -532,7 +532,7 @@ class WebRequest {
* @return int|null
*/
public function getIntOrNull( $name ) {
$val = $this->getVal( $name );
$val = $this->getRawVal( $name );
return is_numeric( $val )
? intval( $val )
: null;
@ -549,7 +549,7 @@ class WebRequest {
* @return float
*/
public function getFloat( $name, $default = 0.0 ) {
return floatval( $this->getVal( $name, $default ) );
return floatval( $this->getRawVal( $name, $default ) );
}
/**
@ -562,7 +562,7 @@ class WebRequest {
* @return bool
*/
public function getBool( $name, $default = false ) {
return (bool)$this->getVal( $name, $default );
return (bool)$this->getRawVal( $name, $default );
}
/**
@ -575,7 +575,8 @@ class WebRequest {
* @return bool
*/
public function getFuzzyBool( $name, $default = false ) {
return $this->getBool( $name, $default ) && strcasecmp( $this->getVal( $name ), 'false' ) !== 0;
return $this->getBool( $name, $default )
&& strcasecmp( $this->getRawVal( $name ), 'false' ) !== 0;
}
/**
@ -589,7 +590,7 @@ class WebRequest {
public function getCheck( $name ) {
# Checkboxes and buttons are only present when clicked
# Presence connotes truth, absence false
return $this->getVal( $name, null ) !== null;
return $this->getRawVal( $name, null ) !== null;
}
/**