Move several legacy style rules to existing dedicated modules

These are often two or three css rules and can be included in the
style sheets of other modules.

To facilitate a good migration from mw-warning-with-logexcerpt,
mw-logevent-loglines has been added to the log event list of
LogEventsList, to allow styling previously provided under
mw-warning-with-logexcerpt to be selected only in cases where
the styles should actually be applied. See also T278002.

Bug: T278576
Change-Id: I3f45c95d2856c8fce2da5175b52089d4e629a41e

includes/logging/LogEventsList.php

@@ -351,7 +351,7 @@ class LogEventsList extends ContextSource {
 	 * @return string
 	 */
 	public function beginLogEventsList() {
-		return "<ul>\n";
+		return "<ul class='mw-logevent-loglines'>\n";
 	}
 
 	/**

includes/specials/SpecialMovepage.php

@@ -220,7 +220,10 @@ class MovePageForm extends UnlistedSpecialPage {
 
 		$out = $this->getOutput();
 		$out->setPageTitle( $this->msg( 'move-page', $this->oldTitle->getPrefixedText() ) );
-		$out->addModuleStyles( 'mediawiki.special' );
+		$out->addModuleStyles( [
+			'mediawiki.special',
+			'mediawiki.interface.helpers.styles'
+		] );
 		$out->addModules( 'mediawiki.misc-authed-ooui' );
 		$this->addHelpLink( 'Help:Moving a page' );
 

resources/src/mediawiki.skinning/legacy.less

@@ -132,14 +132,6 @@ span.history-deleted {
 /**
  * Patrol stuff
  */
-.not-patrolled {
-	background-color: #ffa;
-}
-
-.unpatrolled {
-	font-weight: bold;
-	color: #d33;
-}
 
 div.patrollink {
 	font-size: 75%;
@@ -163,11 +155,6 @@ td.mw-submit {
 	white-space: nowrap;
 }
 
-.mw-input-with-label {
-	white-space: nowrap;
-	display: inline-block;
-}
-
 /**
  * Image captions.
  *
@@ -213,26 +200,12 @@ p.mw-delete-editreasons {
 	color: #72777d;
 }
 
-/** Generic minor/bot/newpage styling (recent changes) */
-.newpage,
-.minoredit,
-.botedit {
-	font-weight: bold;
-}
-
 /**
  * Recreating deleted page warning
  * Reupload file warning
  * Page protection warning
  * incl. log entries for these warnings
  */
-.mw-warning-with-logexcerpt {
-	clear: both;
-}
-
-.mw-warning-with-logexcerpt ul li {
-	font-size: 90%;
-}
 
 /* (show/hide) revision deletion links */
 span.mw-revdelundel-link,
@@ -245,12 +218,6 @@ input.mw-revdelundel-hidden {
 	visibility: hidden;
 }
 
-td.mw-revdel-checkbox,
-th.mw-revdel-checkbox {
-	padding-right: 10px;
-	text-align: center;
-}
-
 /* red links; see T38276 */
 a.new {
 	color: #ba0000;

resources/src/mediawiki.skinning/messageBoxes.less

@@ -28,6 +28,11 @@
 		font-size: 1em;
 		font-weight: bold;
 	}
+
+	// Formerly provided by mw-warning-with-logexcerpt, now available for all messageboxes.
+	.mw-logevent-loglines li {
+		font-size: 90%;
+	}
 }
 
 .messagebox {

resources/src/mediawiki.special.changeslist/changeslist.less

@@ -22,3 +22,8 @@
 	unicode-bidi: -moz-isolate;
 	unicode-bidi: isolate;
 }
+
+.mw-input-with-label {
+	white-space: nowrap;
+	display: inline-block;
+}

resources/src/mediawiki.special.changeslist/default.less

@@ -1,3 +1,5 @@
+/* stylelint-disable selector-class-pattern */
+
 /*
  * Styling for Special:Watchlist and Special:RecentChanges
  */
@@ -44,3 +46,14 @@
 .mw-rcfilters-ui-highlights {
 	display: none;
 }
+
+.unpatrolled {
+	font-weight: bold;
+	color: #d33;
+}
+
+.newpage,
+.minoredit,
+.botedit {
+	font-weight: bold;
+}

resources/src/mediawiki.special/newpages.less

@@ -1,3 +1,5 @@
+/* stylelint-disable selector-class-pattern */
+
 /*!
  * Styles for Special:NewPages
  */
@@ -12,3 +14,7 @@
 .mw-htmlform-ooui .mw-htmlform-submit-buttons + div {
 	margin-top: @ooui-spacing-medium;
 }
+
+.not-patrolled {
+	background-color: #ffa;
+}

resources/src/mediawiki.special/special.less

@@ -137,6 +137,12 @@
 	text-align: right;
 }
 
+td.mw-revdel-checkbox,
+th.mw-revdel-checkbox {
+	padding-right: 10px;
+	text-align: center;
+}
+
 /* Special:Specialpages */
 .mw-specialpagerestricted {
 	font-weight: bold;