Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add missing credits from r75975

Browse source 
Remove a few unused array keys in API foreach loops

Remove part of Html::Hidden comment
This commit is contained in:
Sam Reed 2010-11-06 15:10:18 +00:00
parent 77e631ae23
commit 84fed26fd4
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CREDITS
View file

@ -91,6 +91,7 @@ following names for their contribution to the product.
* Jidanni
* Jimmy Xu
* John Du Hart
* Jonathan Wiltshire
* Karun Dambietz
* Kim Hyun-Joon
* Lee Worden

3
includes/Html.php
View file

@ -547,8 +547,7 @@ class Html {
}
/**
* Convenience function to produce an input element with type=hidden, like
* Xml::hidden.
* Convenience function to produce an input element with type=hidden
*
* @param $name string name attribute
* @param $value string value attribute

4
includes/api/ApiMain.php
View file

@ -833,7 +833,7 @@ class ApiMain extends ApiBase {
$astriks = str_repeat( '*** ', 10 );
$msg .= "\n\n$astriks Modules $astriks\n\n";
foreach ( $this->mModules as $moduleName => $unused ) {
foreach ( $this->mModules as $moduleName ) {
$module = new $this->mModules[$moduleName] ( $this, $moduleName );
$msg .= self::makeHelpMsgHeader( $module, 'action' );
$msg2 = $module->makeHelpMsg();
@ -852,7 +852,7 @@ class ApiMain extends ApiBase {
}
$msg .= "\n$astriks Formats $astriks\n\n";
foreach ( $this->mFormats as $formatName => $unused ) {
foreach ( $this->mFormats as $formatName ) {
$module = $this->createPrinterByName( $formatName );
$msg .= self::makeHelpMsgHeader( $module, 'format' );
$msg2 = $module->makeHelpMsg();

2
includes/api/ApiPageSet.php
View file

@ -501,7 +501,7 @@ class ApiPageSet extends ApiQueryBase {
if ( $processTitles ) {
// The remaining titles in $remaining are non-existent pages
foreach ( $remaining as $ns => $dbkeys ) {
foreach ( $dbkeys as $dbkey => $unused ) {
foreach ( $dbkeys as $dbkey ) {
$title = Title::makeTitle( $ns, $dbkey );
$this->mAllPages[$ns][$dbkey] = $this->mFakePageId;
$this->mMissingTitles[$this->mFakePageId] = $title;

2
includes/api/ApiParse.php
View file

@ -345,7 +345,7 @@ class ApiParse extends ApiBase {
private function formatIWLinks( $iw ) {
$result = array();
foreach ( $iw as $prefix => $titles ) {
foreach ( $titles as $title => $id ) {
foreach ( $titles as $title ) {
$entry = array();
$entry['prefix'] = $prefix;