Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory

Browse source 
Change-Id: I3fddf30f1b0fc2cce79f652cb71efba119439a9f
This commit is contained in:
Kunal Mehta 2019-06-04 15:45:38 -04:00
parent d061c27f45
commit 8665536045
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/htmlform/HTMLForm.php
View file

@ -21,8 +21,6 @@
* @file
*/
use Wikimedia\ObjectFactory;
/**
* Object handling generic submission, CSRF protection, layout and
* other logic for UI forms. in a reusable manner.
@ -304,12 +302,11 @@ class HTMLForm extends ContextSource {
switch ( $displayFormat ) {
case 'vform':
return ObjectFactory::constructClassInstance( VFormHTMLForm::class, $arguments );
return new VFormHTMLForm( ...$arguments );
case 'ooui':
return ObjectFactory::constructClassInstance( OOUIHTMLForm::class, $arguments );
return new OOUIHTMLForm( ...$arguments );
default:
/** @var HTMLForm $form */
$form = ObjectFactory::constructClassInstance( self::class, $arguments );
$form = new self( ...$arguments );
$form->setDisplayFormat( $displayFormat );
return $form;
}