Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "diff: Wrap condition around brackets for more readability"

Browse source
This commit is contained in:
jenkins-bot 2019-04-16 18:46:20 +00:00 committed by Gerrit Code Review
commit 86dacb5de2
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/diff/DifferenceEngine.php
View file

@ -1733,16 +1733,16 @@ class DifferenceEngine extends ContextSource {
* by the request context); if oldid is 0, then compare the revision in newid to the
* immediately previous one.
*
* If oldid is false, leave the corresponding revision object set
* to false. This can happen with 'diff=prev' pointing to a non-existent revision,
* and is also used directly by the API.
* If oldid is false, leave the corresponding revision object set to false. This can
* happen with 'diff=prev' pointing to a non-existent revision, and is also used directly
* by the API.
*
* @return bool Whether both revisions were loaded successfully. Setting mOldRev
* to false counts as successful loading.
*/
public function loadRevisionData() {
if ( $this->mRevisionsLoaded ) {
return $this->isContentOverridden || $this->mNewRev && !is_null( $this->mOldRev );
return $this->isContentOverridden || ( $this->mOldRev !== null && $this->mNewRev !== null );
}
// Whether it succeeds or fails, we don't want to try again