Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove is_scalar check on array

Browse source 
is_array is called before is_scalar and arrays are not scalar

Change-Id: I73e65ac8bce95e31a2c5da7a48a212ce35fb4f40
This commit is contained in:
Umherirrender 2020-06-19 19:23:17 +02:00
parent 7ba2e0aed3
commit 8919239236
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/language/Message.php
View file

@ -1200,15 +1200,12 @@ class Message implements MessageSpecifier, Serializable {
} elseif ( isset( $param['list'] ) ) {
return $this->formatListParam( $param['list'], $param['type'], $format );
} else {
if ( !is_scalar( $param ) ) {
$param = serialize( $param );
}
LoggerFactory::getInstance( 'Bug58676' )->warning(
'Invalid parameter for message "{msgkey}": {param}',
[
'exception' => new Exception,
'msgkey' => $this->getKey(),
'param' => htmlspecialchars( $param ),
'param' => htmlspecialchars( serialize( $param ) ),
]
);