From 8e16fa453e7cd30cc9502aa1d503fe0b29b1d9f4 Mon Sep 17 00:00:00 2001
From: jdlrobson <jdlrobson@gmail.com>
Date: Mon, 25 Oct 2021 09:56:51 -0700
Subject: [PATCH] Selected links should not be red.

Bug: T236608
Change-Id: I949b51c0efcb883ce0d9dac4fbae956fdc467be9
---
 includes/skins/SkinTemplate.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index e0cd10e5eeb..71a1a589af9 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -1011,7 +1011,12 @@ class SkinTemplate extends Skin {
 		}
 		$exists = true;
 		if ( $checkEdit && !$title->isKnown() ) {
-			$classes[] = 'new';
+			// Selected tabs should not show as red link. It doesn't make sense
+			// to show a red link on a page the user has already navigated to.
+			// https://phabricator.wikimedia.org/T294129#7451549
+			if ( !$selected ) {
+				$classes[] = 'new';
+			}
 			$exists = false;
 			if ( $query !== '' ) {
 				$query = 'action=edit&redlink=1&' . $query;