Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

API: Deprecate use of ApiPurge via GET

Browse source 
This emits a warning and logs feature usage, and also pretends that POST
is required in the help and paraminfo output.

Bug: T145649
Change-Id: Ied8d47a947662158fddab383c764bf70c5ab0112
This commit is contained in:
Brad Jorsch 2016-09-14 11:04:33 -04:00
parent fd4858b608
commit 8e461ca44e
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
includes/api/ApiPurge.php
View file

@ -37,6 +37,12 @@ class ApiPurge extends ApiBase {
* Purges the cache of a page
*/
public function execute() {
$main = $this->getMain();
if ( !$main->isInternalMode() && !$main->getRequest()->wasPosted() ) {
$this->logFeatureUsage( 'purge-via-GET' );
$this->setWarning( 'Use of action=purge via GET is deprecated. Use POST instead.' );
}
$params = $this->extractRequestParams();
$continuationManager = new ApiContinuationManager( $this, [], [] );
@ -158,6 +164,18 @@ class ApiPurge extends ApiBase {
return !$this->getUser()->isAllowed( 'purge' );
}
protected function getHelpFlags() {
$flags = parent::getHelpFlags();
// Claim that we must be posted for the purposes of help and paraminfo.
// @todo Remove this when self::mustBePosted() is updated for T145649
if ( !in_array( 'mustbeposted', $flags, true ) ) {
$flags[] = 'mustbeposted';
}
return $flags;
}
public function getAllowedParams( $flags = 0 ) {
$result = [
'forcelinkupdate' => false,