Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the feature switch for disabling autopatrol logging

Browse source 
Per the RFC, it will now become the default and only behaviour
to not log autpatrol actions. The information is already
recorded via the rc_patrolled field.

Bug: T184485
Change-Id: I98ae895a2b4cde4bb945f1df23be4a070b0bf9c4
This commit is contained in:
Amir Sarabadani 2018-04-12 21:03:44 +02:00 committed by Krinkle
parent 93a531f935
commit 922be51066
4 changed files with 3 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/DefaultSettings.php
View file

@ -6862,14 +6862,6 @@ $wgUseNPPatrol = true;
*/
$wgUseFilePatrol = true;
/**
* Log autopatrol actions to the log table
* The default used to be true before 1.31
*
* @since 1.22
*/
$wgLogAutopatrol = false;
/**
* Provide syndication feeds (RSS, Atom) for, e.g., Recentchanges, Newpages
*/

6
includes/changes/RecentChange.php
View file

@ -704,9 +704,6 @@ class RecentChange {
function () use ( $rc, $tags ) {
$rc->addTags( $tags );
$rc->save();
if ( $rc->mAttribs['rc_patrolled'] ) {
PatrolLog::record( $rc, true, $rc->getPerformer() );
}
},
DeferredUpdates::POSTSEND,
wfGetDB( DB_MASTER )
@ -780,9 +777,6 @@ class RecentChange {
function () use ( $rc, $tags ) {
$rc->addTags( $tags );
$rc->save();
if ( $rc->mAttribs['rc_patrolled'] ) {
PatrolLog::record( $rc, true, $rc->getPerformer() );
}
},
DeferredUpdates::POSTSEND,
wfGetDB( DB_MASTER )

7
includes/logging/LogEntry.php
View file

@ -782,13 +782,6 @@ class ManualLogEntry extends LogEntryBase {
if ( $to === 'udp' || $to === 'rcandudp' ) {
$rc->notifyRCFeeds();
}
// Log the autopatrol if the log entry is patrollable
if ( $this->getIsPatrollable() &&
$rc->getAttribute( 'rc_patrolled' ) === RecentChange::PRC_AUTOPATROLLED
) {
PatrolLog::record( $rc, true, $this->getPerformer() );
}
}
},
DeferredUpdates::POSTSEND,

7
includes/logging/PatrolLog.php
View file

@ -27,6 +27,7 @@
* logs of patrol events
*/
class PatrolLog {
/**
* Record a log event for a change being patrolled
*
@ -39,10 +40,8 @@ class PatrolLog {
* @return bool
*/
public static function record( $rc, $auto = false, User $user = null, $tags = null ) {
global $wgLogAutopatrol;
// do not log autopatrolled edits if setting disables it
if ( $auto && !$wgLogAutopatrol ) {
// Do not log autopatrol actions: T184485
if ( $auto ) {
return false;
}