Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Work around hhvm bug in redis job queue

Browse source 
The hhvm redis client returns false instead of null.  This caused
JobQueueRedis to get stuck in an infinite loop.  This works around the
difference by catching null as a signal for no more jobs.

It can be reverted when https://github.com/facebook/hhvm/pull/3127/ is
in all versions of hhvm we expect to run MediaWiki.

Bug: 67622
Change-Id: I9bbad42f36a80635097b8e0140b48b6492b2f0f5
This commit is contained in:
Nik Everett 2014-07-07 16:17:39 -04:00
parent 0d847cb55d
commit 95bfc8b956
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/jobqueue/JobQueueRedis.php
View file

@ -313,7 +313,7 @@ LUA;
} else {
$blob = $this->popAndDeleteBlob( $conn );
}
if ( $blob === false ) {
if ( !is_string( $blob ) ) {
break; // no jobs; nothing to do
}