Merge "Split FallbackContentHandlerTest into separate unit tests"

This commit is contained in:
jenkins-bot 2021-03-30 18:03:30 +00:00 committed by Gerrit Code Review
commit 98cfa1c07d
2 changed files with 110 additions and 95 deletions

View file

@ -1,106 +1,14 @@
<?php
use MediaWiki\Revision\SlotRecord;
use MediaWiki\Revision\SlotRenderingProvider;
/**
* See also unit tests at \MediaWiki\Tests\Unit\FallbackContentHandlerTest
*
* @group ContentHandler
*/
class FallbackContentHandlerTest extends MediaWikiLangTestCase {
/**
* @covers FallbackContentHandler::supportsDirectEditing
*/
public function testSupportsDirectEditing() {
$handler = new FallbackContentHandler( 'horkyporky' );
$this->assertFalse( $handler->supportsDirectEditing(), 'direct editing supported' );
}
/**
* @covers FallbackContentHandler::serializeContent
*/
public function testSerializeContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = new FallbackContent( 'hello world', 'horkyporky' );
$this->assertEquals( 'hello world', $handler->serializeContent( $content ) );
$this->assertEquals(
'hello world',
$handler->serializeContent( $content, 'application/horkyporky' )
);
}
/**
* @covers FallbackContentHandler::unserializeContent
*/
public function testUnserializeContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = $handler->unserializeContent( 'hello world' );
$this->assertEquals( 'hello world', $content->getData() );
$content = $handler->unserializeContent( 'hello world', 'application/horkyporky' );
$this->assertEquals( 'hello world', $content->getData() );
}
/**
* @covers FallbackContentHandler::makeEmptyContent
*/
public function testMakeEmptyContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = $handler->makeEmptyContent();
$this->assertTrue( $content->isEmpty() );
$this->assertSame( '', $content->getData() );
}
public static function dataIsSupportedFormat() {
return [
[ null, true ],
[ 'application/octet-stream', true ],
[ 'unknown/unknown', true ],
[ 'text/plain', false ],
[ 99887766, false ],
];
}
/**
* @dataProvider dataIsSupportedFormat
* @covers FallbackContentHandler::isSupportedFormat
*/
public function testIsSupportedFormat( $format, $supported ) {
$handler = new FallbackContentHandler( 'horkyporky' );
$this->assertEquals( $supported, $handler->isSupportedFormat( $format ) );
}
/**
* @covers ContentHandler::getSecondaryDataUpdates
*/
public function testGetSecondaryDataUpdates() {
$title = Title::newFromText( 'Somefile.jpg', NS_FILE );
$content = new FallbackContent( '', 'horkyporky' );
/** @var SlotRenderingProvider $srp */
$srp = $this->createMock( SlotRenderingProvider::class );
$handler = new FallbackContentHandler( 'horkyporky' );
$updates = $handler->getSecondaryDataUpdates( $title, $content, SlotRecord::MAIN, $srp );
$this->assertEquals( [], $updates );
}
/**
* @covers ContentHandler::getDeletionUpdates
*/
public function testGetDeletionUpdates() {
$title = Title::newFromText( 'Somefile.jpg', NS_FILE );
$handler = new FallbackContentHandler( 'horkyporky' );
$updates = $handler->getDeletionUpdates( $title, SlotRecord::MAIN );
$this->assertEquals( [], $updates );
}
/**
* @covers ContentHandler::getDeletionUpdates
* @covers ContentHandler::getSlotDiffRenderer
*/
public function testGetSlotDiffRenderer() {
$context = new RequestContext();

View file

@ -0,0 +1,107 @@
<?php
namespace MediaWiki\Tests\Unit;
use FallbackContent;
use FallbackContentHandler;
use MediaWiki\Revision\SlotRecord;
use MediaWiki\Revision\SlotRenderingProvider;
use MediaWikiUnitTestCase;
use Title;
/**
* Split from \FallbackContentHandlerTest integration tests
*
* @group ContentHandler
* @coversDefaultClass \FallbackContentHandler
*/
class FallbackContentHandlerTest extends MediaWikiUnitTestCase {
/**
* @covers ::supportsDirectEditing
*/
public function testSupportsDirectEditing() {
$handler = new FallbackContentHandler( 'horkyporky' );
$this->assertFalse( $handler->supportsDirectEditing(), 'direct editing supported' );
}
/**
* @covers ::serializeContent
*/
public function testSerializeContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = new FallbackContent( 'hello world', 'horkyporky' );
$this->assertEquals( 'hello world', $handler->serializeContent( $content ) );
$this->assertEquals(
'hello world',
$handler->serializeContent( $content, 'application/horkyporky' )
);
}
/**
* @covers ::unserializeContent
*/
public function testUnserializeContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = $handler->unserializeContent( 'hello world' );
$this->assertEquals( 'hello world', $content->getData() );
$content = $handler->unserializeContent( 'hello world', 'application/horkyporky' );
$this->assertEquals( 'hello world', $content->getData() );
}
/**
* @covers ::makeEmptyContent
*/
public function testMakeEmptyContent() {
$handler = new FallbackContentHandler( 'horkyporky' );
$content = $handler->makeEmptyContent();
$this->assertTrue( $content->isEmpty() );
$this->assertSame( '', $content->getData() );
}
public function dataIsSupportedFormat() {
return [
[ null, true ],
[ 'application/octet-stream', true ],
[ 'unknown/unknown', true ],
[ 'text/plain', false ],
[ 99887766, false ],
];
}
/**
* @dataProvider dataIsSupportedFormat
* @covers ::isSupportedFormat
*/
public function testIsSupportedFormat( $format, $supported ) {
$handler = new FallbackContentHandler( 'horkyporky' );
$this->assertEquals( $supported, $handler->isSupportedFormat( $format ) );
}
/**
* @covers ::getSecondaryDataUpdates
*/
public function testGetSecondaryDataUpdates() {
$title = $this->createMock( Title::class );
$content = new FallbackContent( '', 'horkyporky' );
$srp = $this->createMock( SlotRenderingProvider::class );
$handler = new FallbackContentHandler( 'horkyporky' );
$updates = $handler->getSecondaryDataUpdates( $title, $content, SlotRecord::MAIN, $srp );
$this->assertEquals( [], $updates );
}
/**
* @covers ::getDeletionUpdates
*/
public function testGetDeletionUpdates() {
$title = $this->createMock( Title::class );
$handler = new FallbackContentHandler( 'horkyporky' );
$updates = $handler->getDeletionUpdates( $title, SlotRecord::MAIN );
$this->assertEquals( [], $updates );
}
}