Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove a hack, and a hack for the hack, for MediaWiki UI input fields

Browse source 
Hack #1: We were ignoring the 'size' attribute of input fields when
  $wgUseMediaWikiUIEverywhere was true. Let's not do that.

Hack #2: We were setting a min-width for MediaWiki UI input fields,
  because fields which were supposed to be full-line were becoming
  tiny because of hack #1. Let's not do that either.

Bug: T92498
Change-Id: I1d2c6c9eb60b52a7267c122a719cfdaa1f74f815
This commit is contained in:
Bartosz Dziewoński 2015-03-13 20:22:02 +01:00
parent 896fdb3d97
commit 98ef0a2f5d
2 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/Html.php
View file

@ -151,10 +151,6 @@ class Html {
} else {
$attrs['class'] = 'mw-ui-input';
}
// Note that size can effect the desired width rendering of mw-ui-input elements
// so it is removed. Left intact when mediawiki ui not enabled.
unset( $attrs['size'] );
}
return $attrs;
}

8
resources/src/mediawiki.ui/components/inputs.less
View file

@ -128,11 +128,3 @@ input.mw-ui-input-large {
font-weight: bold;
line-height: 1.25em;
}
// Tablet and desktop specific styling tweaks.
@media all and (min-width: 768px) {
// Make inline elements take up a sensible amount of the screen on wider devices.
.mw-ui-input-inline {
min-width: 320px;
}
}