rdbms: Annotate ReplaceQueryBuilder::rows as list

Annotate InsertQueryBuilder::rows the same

Change-Id: Idb828d9fd15a10890830ce7d381c266f6b8f19a3

includes/libs/rdbms/querybuilder/InsertQueryBuilder.php

@@ -25,7 +25,7 @@ class InsertQueryBuilder {
 	private $table = '';
 
 	/**
-	 * @var array The rows to be passed to IDatabase::insert()
+	 * @var list<array> The rows to be passed to IDatabase::insert()
 	 */
 	private $rows = [];
 
@@ -193,7 +193,7 @@ class InsertQueryBuilder {
 	/**
 	 * Add rows to be inserted.
 	 *
-	 * @param array $rows
+	 * @param list<array> $rows
 	 * $rows should be an integer-keyed list of such string-keyed maps, defining a list of new rows.
 	 * The keys in each map must be identical to each other and in the same order.
 	 * The rows must not collide with each other.

includes/libs/rdbms/querybuilder/ReplaceQueryBuilder.php

@@ -25,7 +25,7 @@ class ReplaceQueryBuilder {
 	private $table = '';
 
 	/**
-	 * @var array The rows to be passed to IDatabase::replace()
+	 * @var list<array> The rows to be passed to IDatabase::replace()
 	 */
 	private $rows = [];
 
@@ -124,7 +124,7 @@ class ReplaceQueryBuilder {
 	/**
 	 * Add rows to be inserted.
 	 *
-	 * @param array $rows
+	 * @param list<array> $rows
 	 *   $rows should be an integer-keyed list of such string-keyed maps, defining a list of new rows.
 	 *   The keys in each map must be identical to each other and in the same order.
 	 *   The rows must not collide with each other.

tests/phan/TaintCheckAnnotationsTest.php

@@ -3,6 +3,7 @@
 // phpcs:disable
 
 /* @phan-file-suppress PhanTypeSuspiciousEcho, PhanTypeConversionFromArray, PhanPluginUseReturnValueInternalKnown, PhanNoopNew */
+/* @phan-file-suppress PhanTypeMismatchArgument Ignore list/array mismatch for taint checks */
 
 /*
  * This test ensures that taint-check knows about unsafe methods in MediaWiki. Knowledge about those methods