Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

NewPagesPager: remove unused UserFactory

Browse source 
Change-Id: I6db722914669c92613ff7b0d9f87fd8adf1a52c7
This commit is contained in:
Petr Pchelko 2021-05-26 11:43:09 -07:00 committed by DannyS712
parent 358340e7a6
commit 9d1b346c77
3 changed files with 4 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/specialpage/SpecialPageFactory.php
View file

@ -530,7 +530,6 @@ class SpecialPageFactory {
'RevisionLookup',
'NamespaceInfo',
'UserOptionsLookup',
'UserFactory',
]
],
'Recentchanges' => [

15
includes/specials/SpecialNewpages.php
View file

@ -28,7 +28,6 @@ use MediaWiki\Revision\MutableRevisionRecord;
use MediaWiki\Revision\RevisionLookup;
use MediaWiki\Revision\RevisionRecord;
use MediaWiki\Revision\SlotRecord;
use MediaWiki\User\UserFactory;
use MediaWiki\User\UserIdentityValue;
use MediaWiki\User\UserOptionsLookup;
use Wikimedia\Rdbms\ILoadBalancer;
@ -72,9 +71,6 @@ class SpecialNewpages extends IncludableSpecialPage {
/** @var UserOptionsLookup */
private $userOptionsLookup;
/** @var UserFactory */
private $userFactory;
/**
* @param LinkBatchFactory $linkBatchFactory
* @param CommentStore $commentStore
@ -84,7 +80,6 @@ class SpecialNewpages extends IncludableSpecialPage {
* @param RevisionLookup $revisionLookup
* @param NamespaceInfo $namespaceInfo
* @param UserOptionsLookup $userOptionsLookup
* @param UserFactory $userFactory
*/
public function __construct(
LinkBatchFactory $linkBatchFactory,
@ -94,8 +89,7 @@ class SpecialNewpages extends IncludableSpecialPage {
ILoadBalancer $loadBalancer,
RevisionLookup $revisionLookup,
NamespaceInfo $namespaceInfo,
UserOptionsLookup $userOptionsLookup,
UserFactory $userFactory
UserOptionsLookup $userOptionsLookup
) {
parent::__construct( 'Newpages' );
$this->linkBatchFactory = $linkBatchFactory;
@ -106,7 +100,6 @@ class SpecialNewpages extends IncludableSpecialPage {
$this->revisionLookup = $revisionLookup;
$this->namespaceInfo = $namespaceInfo;
$this->userOptionsLookup = $userOptionsLookup;
$this->userFactory = $userFactory;
}
/**
@ -235,8 +228,7 @@ class SpecialNewpages extends IncludableSpecialPage {
$this->getHookContainer(),
$this->groupPermissionsLookup,
$this->loadBalancer,
$this->namespaceInfo,
$this->userFactory
$this->namespaceInfo
);
$pager->mLimit = $this->opts->getValue( 'limit' );
$pager->mOffset = $this->opts->getValue( 'offset' );
@ -580,8 +572,7 @@ class SpecialNewpages extends IncludableSpecialPage {
$this->getHookContainer(),
$this->groupPermissionsLookup,
$this->loadBalancer,
$this->namespaceInfo,
$this->userFactory
$this->namespaceInfo
);
$limit = $this->opts->getValue( 'limit' );
$pager->mLimit = min( $limit, $this->getConfig()->get( 'FeedLimit' ) );

9
includes/specials/pagers/NewPagesPager.php
View file

@ -23,7 +23,6 @@ use MediaWiki\Cache\LinkBatchFactory;
use MediaWiki\HookContainer\HookContainer;
use MediaWiki\HookContainer\HookRunner;
use MediaWiki\Permissions\GroupPermissionsLookup;
use MediaWiki\User\UserFactory;
use Wikimedia\Rdbms\ILoadBalancer;
/**
@ -53,9 +52,6 @@ class NewPagesPager extends ReverseChronologicalPager {
/** @var NamespaceInfo */
private $namespaceInfo;
/** @var UserFactory */
private $userFactory;
/**
* @param SpecialNewpages $form
* @param FormOptions $opts
@ -64,7 +60,6 @@ class NewPagesPager extends ReverseChronologicalPager {
* @param GroupPermissionsLookup $groupPermissionsLookup
* @param ILoadBalancer $loadBalancer
* @param NamespaceInfo $namespaceInfo
* @param UserFactory $userFactory
*/
public function __construct(
$form,
@ -73,8 +68,7 @@ class NewPagesPager extends ReverseChronologicalPager {
HookContainer $hookContainer,
GroupPermissionsLookup $groupPermissionsLookup,
ILoadBalancer $loadBalancer,
NamespaceInfo $namespaceInfo,
UserFactory $userFactory
NamespaceInfo $namespaceInfo
) {
// Set database before parent constructor to avoid setting it there with wfGetDB
$this->mDb = $loadBalancer->getConnectionRef( ILoadBalancer::DB_REPLICA );
@ -85,7 +79,6 @@ class NewPagesPager extends ReverseChronologicalPager {
$this->hookRunner = new HookRunner( $hookContainer );
$this->groupPermissionsLookup = $groupPermissionsLookup;
$this->namespaceInfo = $namespaceInfo;
$this->userFactory = $userFactory;
}
public function getQueryInfo() {