Hard deprecate Revision::setUserIdAndName

Bug: T246284
Change-Id: I97d476bbffac99f8169e13a3f7c1dfca967be8ea

RELEASE-NOTES-1.35

@@ -666,6 +666,7 @@ because of Phabricator reports.
   - ::getQueryInfo - use RevisionStore::getQueryInfo instead
   - ::getArchiveQueryInfo - use RevisionStore::getArchiveQueryInfo instead
   - ::isUnpatrolled - use RevisionStore::getRcIdIfUnpatrolled instead
+  - ::setUserIdAndName - use MutableRevisionRecord::setUser instead
 * RecentChange::markPatrolled was deprecated. Use ::doMarkPatrolled instead.
 * The JobRunner class has been converted to a service class.
   Direct construction is deprecated, use MediaWikiServices::getJobRunner.

includes/Revision.php

@@ -471,12 +471,13 @@ class Revision implements IDBAccessObject {
 	 *       since they are mutable.
 	 *
 	 * @since 1.28
-	 * @deprecated since 1.31, please reuse old Revision object
+	 * @deprecated since 1.31 (soft), 1.35 (hard), please reuse old Revision object
 	 * @param int $id User ID
 	 * @param string $name User name
 	 * @throws MWException
 	 */
 	public function setUserIdAndName( $id, $name ) {
+		wfDeprecated( __METHOD__, '1.31' );
 		if ( $this->mRecord instanceof MutableRevisionRecord ) {
 			$user = User::newFromAnyId( intval( $id ), $name, null );
 			$this->mRecord->setUser( $user );

tests/phpunit/includes/RevisionTest.php

@@ -324,6 +324,7 @@ class RevisionTest extends MediaWikiTestCase {
 	 * @covers Revision::setUserIdAndName
 	 */
 	public function testSetUserIdAndName( $inputId, $expectedId, $name ) {
+		$this->hideDeprecated( 'Revision::setUserIdAndName' );
 		$rev = new Revision( [], 0, $this->getMockTitle() );
 		$rev->setUserIdAndName( $inputId, $name );
 		$this->assertSame( $expectedId, $rev->getUser( Revision::RAW ) );