Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge "User: Reset default value for isTemp in loadDefaults"

Browse source
This commit is contained in:
jenkins-bot 2024-06-25 22:05:43 +00:00 committed by Gerrit Code Review
commit 9fa8ea9566
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/user/User.php
View file

@ -1008,6 +1008,7 @@ class User implements Stringable, Authority, UserIdentity, UserEmailContact {
$this->mActorId = $actorId;
$this->mRealName = '';
$this->mEmail = '';
$this->isTemp = null;
$loggedOut = $this->mRequest && !defined( 'MW_NO_SESSION' )
? $this->mRequest->getSession()->getLoggedOutTimestamp() : 0;

12
tests/phpunit/includes/user/UserTest.php
View file

@ -1641,6 +1641,18 @@ class UserTest extends MediaWikiIntegrationTestCase {
$this->assertSame( $expected, $user->isTemp() );
}
/**
* @covers \MediaWiki\User\User::isTemp
*/
public function testSetIsTempInLoadDefaults() {
$this->enableAutoCreateTempUser();
$user = new User();
$user->loadDefaults();
$this->assertSame( false, $user->isTemp() );
$user->loadDefaults( '~2024-1' );
$this->assertSame( true, $user->isTemp() );
}
/**
* @covers \MediaWiki\User\User::isNamed
*/