Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Curl sanity -- dump non-200 return codes and error numbers to debug log at least, rather than just silently failing.

Browse source
This commit is contained in:
Brion Vibber 2008-09-30 19:25:04 +00:00
parent 67740ef9cb
commit 9fdb79cfd2
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/HttpFunctions.php
View file

@ -82,11 +82,16 @@ class Http {
ob_end_clean();
# Don't return the text of error messages, return false on error
if ( curl_getinfo( $c, CURLINFO_HTTP_CODE ) != 200 ) {
$retcode = curl_getinfo( $c, CURLINFO_HTTP_CODE );
if ( $retcode != 200 ) {
wfDebug( __METHOD__ . ": HTTP return code $retcode\n" );
$text = false;
}
# Don't return truncated output
if ( curl_errno( $c ) != CURLE_OK ) {
$errno = curl_errno( $c );
if ( $errno != CURLE_OK ) {
$errstr = curl_error( $c );
wfDebug( __METHOD__ . ": CURL error code $errno: $errstr\n" );
$text = false;
}
curl_close( $c );