Mark CONSTRUCTOR_OPTIONS as internal

These were never meant to be part of the public interface and should not
ever have been marked with @since. They're only useful for constructing
the respective objects, which no outside users should be doing.

Change-Id: I86e01272d46fc72af32172d8a12b9180971d4613

includes/MovePage.php

@@ -106,6 +106,9 @@ class MovePage {
 	 */
 	private $hookRunner;
 
+	/**
+	 * @internal For use by MovePageTest
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'CategoryCollation'
 	];

includes/Permissions/PermissionManager.php

@@ -58,8 +58,7 @@ class PermissionManager {
 	public const RIGOR_SECURE = 'secure';
 
 	/**
-	 * @since 1.34
-	 * @var array
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'WhitelistRead',

includes/Storage/BlobStoreFactory.php

@@ -55,8 +55,7 @@ class BlobStoreFactory {
 	private $options;
 
 	/**
-	 * @var array
-	 * @since 1.34
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'CompressRevisions',

includes/Storage/PageUpdater.php

@@ -80,7 +80,7 @@ class PageUpdater {
 	/**
 	 * Options that have to be present in the ServiceOptions object passed to the constructor.
 	 *
-	 * @since 1.36
+	 * @internal
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'ManualRevertSearchRadius'

includes/block/BlockManager.php

@@ -51,8 +51,7 @@ class BlockManager {
 	private $options;
 
 	/**
-	 * @var array
-	 * @since 1.34
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'ApplyIpBlocksToXff',

includes/block/DatabaseBlockStore.php

@@ -46,6 +46,9 @@ class DatabaseBlockStore {
 	/** @var ServiceOptions */
 	private $options;
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'PutIPinRC',
 		'BlockDisablesLogin',

includes/cache/localisation/LocalisationCache.php

@@ -230,8 +230,7 @@ class LocalisationCache {
 	}
 
 	/**
-	 * @var array
-	 * @since 1.34
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		// True to treat all files as expired until they are regenerated by this object.

includes/db/MWLBFactory.php

@@ -36,8 +36,7 @@ abstract class MWLBFactory {
 	private static $loggedDeprecations = [];
 
 	/**
-	 * @var array
-	 * @since 1.34
+	 * @internal For use by ServiceWiring
 	 */
 	public const APPLY_DEFAULT_CONFIG_OPTIONS = [
 		'DBcompress',

includes/filebackend/FileBackendGroup.php

@@ -63,7 +63,7 @@ class FileBackendGroup {
 	private $objectFactory;
 
 	/**
-	 * @internal
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'DirectoryMode',

includes/http/HttpRequestFactory.php

@@ -41,6 +41,9 @@ class HttpRequestFactory {
 	/** @var LoggerInterface */
 	private $logger;
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'HTTPTimeout',
 		'HTTPConnectTimeout',

includes/jobqueue/JobRunner.php

@@ -40,6 +40,9 @@ use Wikimedia\ScopedCallback;
  */
 class JobRunner implements LoggerAwareInterface {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'JobBackoffThrottling',
 		'JobClasses',

includes/language/LanguageFactory.php

@@ -65,8 +65,7 @@ class LanguageFactory {
 	private $parentLangCache = [];
 
 	/**
-	 * @since 1.35
-	 * @var array
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'DummyLanguageCodes',

includes/language/LanguageNameUtils.php

@@ -75,6 +75,9 @@ class LanguageNameUtils {
 	 */
 	private $validCodeCache = [];
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'ExtraLanguageNames',
 		'UsePigLatinVariant',

includes/page/PageCommandFactory.php

@@ -75,6 +75,9 @@ class PageCommandFactory implements ContentModelChangeFactory, MergeHistoryFacto
 	/** @var HookContainer */
 	private $hookContainer;
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'CategoryCollation'
 	];

includes/parser/Parser.php

@@ -360,8 +360,7 @@ class Parser {
 	private $hookRunner;
 
 	/**
-	 * @var array
-	 * @since 1.35
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		// Deprecated and unused; from $wgParserConf

includes/preferences/DefaultPreferencesFactory.php

@@ -92,8 +92,7 @@ class DefaultPreferencesFactory implements PreferencesFactory {
 	private $hookRunner;
 
 	/**
-	 * @var array
-	 * @since 1.34
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'AllowRequiringEmailForResets',

includes/specialpage/SpecialPageFactory.php

@@ -298,8 +298,7 @@ class SpecialPageFactory {
 	private $hookRunner;
 
 	/**
-	 * @var array
-	 * @since 1.35
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'DisableInternalSearch',

includes/title/NamespaceInfo.php

@@ -83,8 +83,7 @@ class NamespaceInfo {
 	];
 
 	/**
-	 * @since 1.34
-	 * @internal
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'AllowImageMoving',

includes/user/DefaultOptionsLookup.php

@@ -34,6 +34,9 @@ use Wikimedia\Assert\Assert;
  */
 class DefaultOptionsLookup extends UserOptionsLookup {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'DefaultSkin',
 		'DefaultUserOptions',

includes/user/PasswordReset.php

@@ -68,6 +68,9 @@ class PasswordReset implements LoggerAwareInterface {
 	 */
 	private $permissionCache;
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'AllowRequiringEmailForResets',
 		'EnableEmail',

includes/user/TalkPageNotificationManager.php

@@ -34,6 +34,9 @@ use Wikimedia\Rdbms\ILoadBalancer;
  */
 class TalkPageNotificationManager {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'DisableAnonTalk'
 	];

includes/user/UserGroupManager.php

@@ -50,6 +50,9 @@ use Wikimedia\Rdbms\ILoadBalancer;
  */
 class UserGroupManager implements IDBAccessObject {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'Autopromote',
 		'AutopromoteOnce',

includes/user/UserNameUtils.php

@@ -41,6 +41,9 @@ use Wikimedia\Message\MessageValue;
  */
 class UserNameUtils {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'MaxNameChars',
 		'ReservedUsernames',

includes/user/UserOptionsManager.php

@@ -43,6 +43,9 @@ use Wikimedia\Rdbms\ILoadBalancer;
  */
 class UserOptionsManager extends UserOptionsLookup {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'HiddenPrefs'
 	];

includes/user/WatchlistNotificationManager.php

@@ -39,6 +39,9 @@ use WatchedItemStoreInterface;
  */
 class WatchlistNotificationManager {
 
+	/**
+	 * @internal For use by ServiceWiring
+	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'UseEnotif',
 		'ShowUpdatedMarker',

includes/watcheditem/WatchedItemStore.php

@@ -26,7 +26,7 @@ use Wikimedia\ScopedCallback;
 class WatchedItemStore implements WatchedItemStoreInterface, StatsdAwareInterface {
 
 	/**
-	 * @since 1.35
+	 * @internal For use by ServiceWiring
 	 */
 	public const CONSTRUCTOR_OPTIONS = [
 		'UpdateRowsPerQuery',