Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add statsd timing for actions

Browse source 
So that we can see how slow history pages are.

Details are by analogy with API action timing.

Bug: T284274
Change-Id: I8a679b8bc94fe2a062b9d62ecff0a7584e65a4db
This commit is contained in:
Tim Starling 2021-06-29 11:30:27 +10:00 committed by DannyS712
parent de03255936
commit a4922b5cc1
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
includes/MediaWiki.php
View file

@ -501,6 +501,7 @@ class MediaWiki {
$output = $this->context->getOutput();
$title = $this->context->getTitle();
$user = $this->context->getUser();
$services = MediaWikiServices::getInstance();
if ( !$this->getHookRunner()->onMediaWikiPerformAction(
$output, $article, $title, $user, $request, $this )
@ -508,8 +509,9 @@ class MediaWiki {
return;
}
$act = $this->getAction();
$action = Action::factory( $act, $article, $this->context );
$t = microtime( true );
$actionName = $this->getAction();
$action = Action::factory( $actionName, $article, $this->context );
if ( $action instanceof Action ) {
// Narrow DB query expectations for this HTTP request
@ -522,7 +524,7 @@ class MediaWiki {
# Let CDN cache things if we can purge them.
if ( $this->config->get( 'UseCdn' ) ) {
$htmlCacheUpdater = MediaWikiServices::getInstance()->getHtmlCacheUpdater();
$htmlCacheUpdater = $services->getHtmlCacheUpdater();
if ( in_array(
// Use PROTO_INTERNAL because that's what HtmlCacheUpdater::getUrls() uses
wfExpandUrl( $request->getRequestURL(), PROTO_INTERNAL ),
@ -534,6 +536,12 @@ class MediaWiki {
}
$action->show();
$runTime = microtime( true ) - $t;
$services->getStatsdDataFactory()->timing(
'action.' . strtr( $actionName, '.', '_' ) . '.executeTiming',
1000 * $runTime
);
return;
}