Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix bad join on ChangeTag subquery

Browse source 
Bug: T207313
Change-Id: Iae6440630a533dfbcee3ccec34a9f231d3d013b5
This commit is contained in:
Amir Sarabadani 2018-10-22 15:53:29 +02:00
parent f23894eb7e
commit a5500e7a0d
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/changetags/ChangeTags.php
View file

@ -807,15 +807,15 @@ class ChangeTags {
$tagTables[] = 'change_tag';
if ( $wgChangeTagsSchemaMigrationStage > MIGRATION_WRITE_BOTH ) {
$tagTables[] = 'change_tag_def';
$join_cond_ts_tags = [ $join_cond, 'ct_tag_id=ctd_id' ];
$join_cond_ts_tags = [ 'change_tag_def' => [ 'INNER JOIN', 'ct_tag_id=ctd_id' ] ];
$field = 'ctd_name';
} else {
$field = 'ct_tag';
$join_cond_ts_tags = $join_cond;
$join_cond_ts_tags = [];
}
$fields['ts_tags'] = wfGetDB( DB_REPLICA )->buildGroupConcatField(
',', $tagTables, $field, $join_cond_ts_tags
',', $tagTables, $field, $join_cond, $join_cond_ts_tags
);
if ( $wgUseTagFilter && $filter_tag ) {