Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

htmlform: Replace some uses of isHidden to isDisabled

Browse source 
After its logic is refactored, we have more faith to use isDisabled() in these cases, which matches the original semantics of isHidden().

Change-Id: I1aece7c691307ac8bb3770e6dc4b8e2877e4d65c
This commit is contained in:
Func 2022-02-20 15:14:50 +00:00
parent 0c8c75436c
commit a745a87216
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/htmlform/HTMLFormField.php
View file

@ -395,7 +395,7 @@ abstract class HTMLFormField {
* false to fail validation without displaying an error.
*/
public function validate( $value, $alldata ) {
if ( $this->isHidden( $alldata ) ) {
if ( $this->isDisabled( $alldata ) ) {
return true;
}

2
includes/htmlform/fields/HTMLFormFieldCloner.php
View file

@ -351,7 +351,7 @@ class HTMLFormFieldCloner extends HTMLFormField {
if ( !array_key_exists( $fieldname, $value ) ) {
continue;
}
if ( $field->isHidden( $alldata ) ) {
if ( $field->isDisabled( $alldata ) ) {
continue;
}
$ok = $field->validate( $value[$fieldname], $alldata );

2
includes/htmlform/fields/HTMLRestrictionsField.php
View file

@ -73,7 +73,7 @@ class HTMLRestrictionsField extends HTMLTextAreaField {
* false to fail validation without displaying an error.
*/
public function validate( $value, $alldata ) {
if ( $this->isHidden( $alldata ) ) {
if ( $this->isDisabled( $alldata ) ) {
return true;
}