Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add missing & to @param documentation to match functon call

Browse source 
Change-Id: I81e68310abcbc59964b22e0e74842d509f6b1fb9
This commit is contained in:
Umherirrender 2017-08-11 02:23:16 +02:00
parent b5ddc3a4b4
commit a9007e8baf
86 changed files with 190 additions and 190 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/AuthPlugin.php
View file

@ -73,8 +73,8 @@ class AuthPlugin {
/** /**
* Modify options in the login template. * Modify options in the login template.
* *
* @param BaseTemplate $template * @param BaseTemplate &$template
* @param string $type 'signup' or 'login'. Added in 1.16. * @param string &$type 'signup' or 'login'. Added in 1.16.
*/ */
public function modifyUITemplate( &$template, &$type ) { public function modifyUITemplate( &$template, &$type ) {
# Override this! # Override this!
@ -124,7 +124,7 @@ class AuthPlugin {
* *
* @deprecated since 1.26, use the UserLoggedIn hook instead. And assigning * @deprecated since 1.26, use the UserLoggedIn hook instead. And assigning
* a different User object to $user is no longer supported. * a different User object to $user is no longer supported.
* @param User $user * @param User &$user
* @return bool * @return bool
*/ */
public function updateUser( &$user ) { public function updateUser( &$user ) {
@ -286,7 +286,7 @@ class AuthPlugin {
* *
* @deprecated since 1.26, use the UserLoggedIn hook instead. And assigning * @deprecated since 1.26, use the UserLoggedIn hook instead. And assigning
* a different User object to $user is no longer supported. * a different User object to $user is no longer supported.
* @param User $user * @param User &$user
* @param bool $autocreate True if user is being autocreated on login * @param bool $autocreate True if user is being autocreated on login
*/ */
public function initUser( &$user, $autocreate = false ) { public function initUser( &$user, $autocreate = false ) {
@ -306,7 +306,7 @@ class AuthPlugin {
/** /**
* Get an instance of a User object * Get an instance of a User object
* *
* @param User $user * @param User &$user
* *
* @return AuthPluginUser * @return AuthPluginUser
*/ */

16
includes/EditPage.php
View file

@ -852,7 +852,7 @@ class EditPage {
/** /**
* This function collects the form data and uses it to populate various member variables. * This function collects the form data and uses it to populate various member variables.
* @param WebRequest $request * @param WebRequest &$request
* @throws ErrorPageError * @throws ErrorPageError
*/ */
public function importFormData( &$request ) { public function importFormData( &$request ) {
@ -1080,7 +1080,7 @@ class EditPage {
* this method should be overridden and return the page text that will be used * this method should be overridden and return the page text that will be used
* for saving, preview parsing and so on... * for saving, preview parsing and so on...
* *
* @param WebRequest $request * @param WebRequest &$request
* @return string|null * @return string|null
*/ */
protected function importContentFormData( &$request ) { protected function importContentFormData( &$request ) {
@ -1432,7 +1432,7 @@ class EditPage {
/** /**
* Make sure the form isn't faking a user's credentials. * Make sure the form isn't faking a user's credentials.
* *
* @param WebRequest $request * @param WebRequest &$request
* @return bool * @return bool
* @private * @private
*/ */
@ -1475,7 +1475,7 @@ class EditPage {
/** /**
* Attempt submission * Attempt submission
* @param array|bool $resultDetails See docs for $result in internalAttemptSave * @param array|bool &$resultDetails See docs for $result in internalAttemptSave
* @throws UserBlockedError|ReadOnlyError|ThrottledError|PermissionsError * @throws UserBlockedError|ReadOnlyError|ThrottledError|PermissionsError
* @return Status The resulting status object. * @return Status The resulting status object.
*/ */
@ -1721,7 +1721,7 @@ class EditPage {
/** /**
* Attempt submission (no UI) * Attempt submission (no UI)
* *
* @param array $result Array to add statuses to, currently with the * @param array &$result Array to add statuses to, currently with the
* possible keys: * possible keys:
* - spam (string): Spam string from content if any spam is detected by * - spam (string): Spam string from content if any spam is detected by
* matchSpamRegex. * matchSpamRegex.
@ -4202,7 +4202,7 @@ class EditPage {
* Returns an array of html code of the following checkboxes old style: * Returns an array of html code of the following checkboxes old style:
* minor and watch * minor and watch
* *
* @param int $tabindex Current tabindex * @param int &$tabindex Current tabindex
* @param array $checked See getCheckboxesDefinition() * @param array $checked See getCheckboxesDefinition()
* @return array * @return array
*/ */
@ -4260,7 +4260,7 @@ class EditPage {
* Returns an array of html code of the following checkboxes: * Returns an array of html code of the following checkboxes:
* minor and watch * minor and watch
* *
* @param int $tabindex Current tabindex * @param int &$tabindex Current tabindex
* @param array $checked Array of checkbox => bool, where bool indicates the checked * @param array $checked Array of checkbox => bool, where bool indicates the checked
* status of the checkbox * status of the checkbox
* *
@ -4345,7 +4345,7 @@ class EditPage {
* Returns an array of html code of the following buttons: * Returns an array of html code of the following buttons:
* save, diff and preview * save, diff and preview
* *
* @param int $tabindex Current tabindex * @param int &$tabindex Current tabindex
* *
* @return array * @return array
*/ */

10
includes/FileDeleteForm.php
View file

@ -143,9 +143,9 @@ class FileDeleteForm {
/** /**
* Really delete the file * Really delete the file
* *
* @param Title $title * @param Title &$title
* @param File $file * @param File &$file
* @param string $oldimage Archive name * @param string &$oldimage Archive name
* @param string $reason Reason of the deletion * @param string $reason Reason of the deletion
* @param bool $suppress Whether to mark all deleted versions as restricted * @param bool $suppress Whether to mark all deleted versions as restricted
* @param User $user User object performing the request * @param User $user User object performing the request
@ -398,8 +398,8 @@ class FileDeleteForm {
* value was provided, does it correspond to an * value was provided, does it correspond to an
* existing, local, old version of this file? * existing, local, old version of this file?
* *
* @param File $file * @param File &$file
* @param File $oldfile * @param File &$oldfile
* @param File $oldimage * @param File $oldimage
* @return bool * @return bool
*/ */

8
includes/GlobalFunctions.php
View file

@ -241,7 +241,7 @@ function wfArrayFilterByKey( array $arr, callable $callback ) {
* @param string|int $key * @param string|int $key
* @param mixed $value * @param mixed $value
* @param mixed $default * @param mixed $default
* @param array $changed Array to alter * @param array &$changed Array to alter
* @throws MWException * @throws MWException
*/ */
function wfAppendToArrayIfNotDefault( $key, $value, $default, &$changed ) { function wfAppendToArrayIfNotDefault( $key, $value, $default, &$changed ) {
@ -1750,7 +1750,7 @@ function wfEscapeWikiText( $text ) {
* If source is NULL, it just returns the value, it doesn't set the variable * If source is NULL, it just returns the value, it doesn't set the variable
* If force is true, it will set the value even if source is NULL * If force is true, it will set the value even if source is NULL
* *
* @param mixed $dest * @param mixed &$dest
* @param mixed $source * @param mixed $source
* @param bool $force * @param bool $force
* @return mixed * @return mixed
@ -1766,7 +1766,7 @@ function wfSetVar( &$dest, $source, $force = false ) {
/** /**
* As for wfSetVar except setting a bit * As for wfSetVar except setting a bit
* *
* @param int $dest * @param int &$dest
* @param int $bit * @param int $bit
* @param bool $state * @param bool $state
* *
@ -2618,7 +2618,7 @@ function wfShellWikiCmd( $script, array $parameters = [], array $options = [] )
* @param string $old * @param string $old
* @param string $mine * @param string $mine
* @param string $yours * @param string $yours
* @param string $result * @param string &$result
* @return bool * @return bool
*/ */
function wfMerge( $old, $mine, $yours, &$result ) { function wfMerge( $old, $mine, $yours, &$result ) {

2
includes/Licenses.php
View file

@ -92,7 +92,7 @@ class Licenses extends HTMLFormField {
} }
/** /**
* @param array $list * @param array &$list
* @param array $path * @param array $path
* @param mixed $item * @param mixed $item
*/ */

2
includes/Linker.php
View file

@ -1350,7 +1350,7 @@ class Linker {
/** /**
* @param Title $contextTitle * @param Title $contextTitle
* @param string $target * @param string $target
* @param string $text * @param string &$text
* @return string * @return string
*/ */
public static function normalizeSubpageLink( $contextTitle, $target, &$text ) { public static function normalizeSubpageLink( $contextTitle, $target, &$text ) {

8
includes/MagicWord.php
View file

@ -518,7 +518,7 @@ class MagicWord {
* Returns true if the text matches the word, and alters the * Returns true if the text matches the word, and alters the
* input string, removing all instances of the word * input string, removing all instances of the word
* *
* @param string $text * @param string &$text
* *
* @return bool * @return bool
*/ */
@ -534,7 +534,7 @@ class MagicWord {
} }
/** /**
* @param string $text * @param string &$text
* @return bool * @return bool
*/ */
public function matchStartAndRemove( &$text ) { public function matchStartAndRemove( &$text ) {
@ -655,7 +655,7 @@ class MagicWord {
* *
* @param array $magicarr * @param array $magicarr
* @param string $subject * @param string $subject
* @param string $result * @param string &$result
* *
* @return bool * @return bool
*/ */
@ -677,7 +677,7 @@ class MagicWord {
* Adds all the synonyms of this MagicWord to an array, to allow quick * Adds all the synonyms of this MagicWord to an array, to allow quick
* lookup in a list of magic words * lookup in a list of magic words
* *
* @param array $array * @param array &$array
* @param string $value * @param string $value
*/ */
public function addToArray( &$array, $value ) { public function addToArray( &$array, $value ) {

4
includes/MagicWordArray.php
View file

@ -260,7 +260,7 @@ class MagicWordArray {
* Returns an associative array, ID => param value, for all items that match * Returns an associative array, ID => param value, for all items that match
* Removes the matched items from the input string (passed by reference) * Removes the matched items from the input string (passed by reference)
* *
* @param string $text * @param string &$text
* *
* @return array * @return array
*/ */
@ -304,7 +304,7 @@ class MagicWordArray {
* Return false if no match found and $text is not modified. * Return false if no match found and $text is not modified.
* Does not match parameters. * Does not match parameters.
* *
* @param string $text * @param string &$text
* *
* @return int|bool False on failure * @return int|bool False on failure
*/ */

6
includes/OutputPage.php
View file

@ -1715,7 +1715,7 @@ class OutputPage extends ContextSource {
* Add wikitext with a custom Title object * Add wikitext with a custom Title object
* *
* @param string $text Wikitext * @param string $text Wikitext
* @param Title $title * @param Title &$title
* @param bool $linestart Is this the start of a line? * @param bool $linestart Is this the start of a line?
*/ */
public function addWikiTextWithTitle( $text, &$title, $linestart = true ) { public function addWikiTextWithTitle( $text, &$title, $linestart = true ) {
@ -1726,7 +1726,7 @@ class OutputPage extends ContextSource {
* Add wikitext with a custom Title object and tidy enabled. * Add wikitext with a custom Title object and tidy enabled.
* *
* @param string $text Wikitext * @param string $text Wikitext
* @param Title $title * @param Title &$title
* @param bool $linestart Is this the start of a line? * @param bool $linestart Is this the start of a line?
*/ */
function addWikiTextTitleTidy( $text, &$title, $linestart = true ) { function addWikiTextTitleTidy( $text, &$title, $linestart = true ) {
@ -1899,7 +1899,7 @@ class OutputPage extends ContextSource {
/** /**
* Add the output of a QuickTemplate to the output buffer * Add the output of a QuickTemplate to the output buffer
* *
* @param QuickTemplate $template * @param QuickTemplate &$template
*/ */
public function addTemplate( &$template ) { public function addTemplate( &$template ) {
$this->addHTML( $template->getHTML() ); $this->addHTML( $template->getHTML() );

20
includes/Preferences.php
View file

@ -109,7 +109,7 @@ class Preferences {
* @throws MWException * @throws MWException
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences Array to load values for * @param array &$defaultPreferences Array to load values for
* @return array|null * @return array|null
*/ */
static function loadPreferenceValues( $user, $context, &$defaultPreferences ) { static function loadPreferenceValues( $user, $context, &$defaultPreferences ) {
@ -202,7 +202,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
* @return void * @return void
*/ */
static function profilePreferences( $user, IContextSource $context, &$defaultPreferences ) { static function profilePreferences( $user, IContextSource $context, &$defaultPreferences ) {
@ -599,7 +599,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
* @return void * @return void
*/ */
static function skinPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function skinPreferences( $user, IContextSource $context, &$defaultPreferences ) {
@ -650,7 +650,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function filesPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function filesPreferences( $user, IContextSource $context, &$defaultPreferences ) {
# # Files ##################################### # # Files #####################################
@ -671,7 +671,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
* @return void * @return void
*/ */
static function datetimePreferences( $user, IContextSource $context, &$defaultPreferences ) { static function datetimePreferences( $user, IContextSource $context, &$defaultPreferences ) {
@ -749,7 +749,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function renderingPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function renderingPreferences( $user, IContextSource $context, &$defaultPreferences ) {
# # Diffs #################################### # # Diffs ####################################
@ -811,7 +811,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function editingPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function editingPreferences( $user, IContextSource $context, &$defaultPreferences ) {
# # Editing ##################################### # # Editing #####################################
@ -884,7 +884,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function rcPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function rcPreferences( $user, IContextSource $context, &$defaultPreferences ) {
$config = $context->getConfig(); $config = $context->getConfig();
@ -960,7 +960,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function watchlistPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function watchlistPreferences( $user, IContextSource $context, &$defaultPreferences ) {
$config = $context->getConfig(); $config = $context->getConfig();
@ -1110,7 +1110,7 @@ class Preferences {
/** /**
* @param User $user * @param User $user
* @param IContextSource $context * @param IContextSource $context
* @param array $defaultPreferences * @param array &$defaultPreferences
*/ */
static function searchPreferences( $user, IContextSource $context, &$defaultPreferences ) { static function searchPreferences( $user, IContextSource $context, &$defaultPreferences ) {
foreach ( MWNamespace::getValidNamespaces() as $n ) { foreach ( MWNamespace::getValidNamespaces() as $n ) {

2
includes/ProtectionForm.php
View file

@ -616,7 +616,7 @@ class ProtectionForm {
/** /**
* Show protection long extracts for this page * Show protection long extracts for this page
* *
* @param OutputPage $out * @param OutputPage &$out
* @access private * @access private
*/ */
function showLogExtract( &$out ) { function showLogExtract( &$out ) {

2
includes/Revision.php
View file

@ -1307,7 +1307,7 @@ class Revision implements IDBAccessObject {
* data is compressed, and 'utf-8' if we're saving in UTF-8 * data is compressed, and 'utf-8' if we're saving in UTF-8
* mode. * mode.
* *
* @param mixed $text Reference to a text * @param mixed &$text Reference to a text
* @return string * @return string
*/ */
public static function compressRevisionText( &$text ) { public static function compressRevisionText( &$text ) {

2
includes/SiteConfiguration.php
View file

@ -345,7 +345,7 @@ class SiteConfiguration {
* @param string $setting ID of the setting name to retrieve * @param string $setting ID of the setting name to retrieve
* @param string $wiki Wiki ID of the wiki in question. * @param string $wiki Wiki ID of the wiki in question.
* @param string $suffix The suffix of the wiki in question. * @param string $suffix The suffix of the wiki in question.
* @param array $var Reference The variable to insert the value into. * @param array &$var Reference The variable to insert the value into.
* @param array $params List of parameters. $.'key' is replaced by $value in all returned data. * @param array $params List of parameters. $.'key' is replaced by $value in all returned data.
* @param array $wikiTags The tags assigned to the wiki. * @param array $wikiTags The tags assigned to the wiki.
*/ */

2
includes/StubObject.php
View file

@ -86,7 +86,7 @@ class StubObject {
* infinite loop when unstubbing an object or to avoid reference parameter * infinite loop when unstubbing an object or to avoid reference parameter
* breakage. * breakage.
* *
* @param object $obj Object to check. * @param object &$obj Object to check.
* @return void * @return void
*/ */
public static function unstub( &$obj ) { public static function unstub( &$obj ) {

4
includes/Title.php
View file

@ -3693,7 +3693,7 @@ class Title implements LinkTarget {
* Returns true if ok, or a getUserPermissionsErrors()-like array otherwise * Returns true if ok, or a getUserPermissionsErrors()-like array otherwise
* *
* @deprecated since 1.25, use MovePage's methods instead * @deprecated since 1.25, use MovePage's methods instead
* @param Title $nt The new title * @param Title &$nt The new title
* @param bool $auth Whether to check user permissions (uses $wgUser) * @param bool $auth Whether to check user permissions (uses $wgUser)
* @param string $reason Is the log summary of the move, used for spam checking * @param string $reason Is the log summary of the move, used for spam checking
* @return array|bool True on success, getUserPermissionsErrors()-like array on failure * @return array|bool True on success, getUserPermissionsErrors()-like array on failure
@ -3745,7 +3745,7 @@ class Title implements LinkTarget {
* Move a title to a new location * Move a title to a new location
* *
* @deprecated since 1.25, use the MovePage class instead * @deprecated since 1.25, use the MovePage class instead
* @param Title $nt The new title * @param Title &$nt The new title
* @param bool $auth Indicates whether $wgUser's permissions * @param bool $auth Indicates whether $wgUser's permissions
* should be checked * should be checked
* @param string $reason The reason for the move * @param string $reason The reason for the move

4
includes/api/ApiBase.php
View file

@ -1432,7 +1432,7 @@ abstract class ApiBase extends ContextSource {
* Validate the value against the minimum and user/bot maximum limits. * Validate the value against the minimum and user/bot maximum limits.
* Prints usage info on failure. * Prints usage info on failure.
* @param string $paramName Parameter name * @param string $paramName Parameter name
* @param int $value Parameter value * @param int &$value Parameter value
* @param int|null $min Minimum value * @param int|null $min Minimum value
* @param int|null $max Maximum value for users * @param int|null $max Maximum value for users
* @param int $botMax Maximum value for sysops/bots * @param int $botMax Maximum value for sysops/bots
@ -1599,7 +1599,7 @@ abstract class ApiBase extends ContextSource {
/** /**
* Truncate an array to a certain length. * Truncate an array to a certain length.
* @param array $arr Array to truncate * @param array &$arr Array to truncate
* @param int $limit Maximum length * @param int $limit Maximum length
* @return bool True if the array was truncated, false otherwise * @return bool True if the array was truncated, false otherwise
*/ */

4
includes/api/ApiDelete.php
View file

@ -106,7 +106,7 @@ class ApiDelete extends ApiBase {
* *
* @param Page|WikiPage $page Page or WikiPage object to work on * @param Page|WikiPage $page Page or WikiPage object to work on
* @param User $user User doing the action * @param User $user User doing the action
* @param string|null $reason Reason for the deletion. Autogenerated if null * @param string|null &$reason Reason for the deletion. Autogenerated if null
* @param array $tags Tags to tag the deletion with * @param array $tags Tags to tag the deletion with
* @return Status * @return Status
*/ */
@ -142,7 +142,7 @@ class ApiDelete extends ApiBase {
* @param Page $page Object to work on * @param Page $page Object to work on
* @param User $user User doing the action * @param User $user User doing the action
* @param string $oldimage Archive name * @param string $oldimage Archive name
* @param string $reason Reason for the deletion. Autogenerated if null. * @param string &$reason Reason for the deletion. Autogenerated if null.
* @param bool $suppress Whether to mark all deleted versions as restricted * @param bool $suppress Whether to mark all deleted versions as restricted
* @param array $tags Tags to tag the deletion with * @param array $tags Tags to tag the deletion with
* @return Status * @return Status

2
includes/api/ApiParamInfo.php
View file

@ -184,7 +184,7 @@ class ApiParamInfo extends ApiBase {
} }
/** /**
* @param array $res Result array * @param array &$res Result array
* @param string $key Result key * @param string $key Result key
* @param Message[] $msgs * @param Message[] $msgs
* @param bool $joinLists * @param bool $joinLists

2
includes/api/ApiQueryBase.php
View file

@ -478,7 +478,7 @@ abstract class ApiQueryBase extends ApiBase {
/** /**
* Add information (title and namespace) about a Title object to a * Add information (title and namespace) about a Title object to a
* result array * result array
* @param array $arr Result array à la ApiResult * @param array &$arr Result array à la ApiResult
* @param Title $title * @param Title $title
* @param string $prefix Module prefix * @param string $prefix Module prefix
*/ */

2
includes/api/ApiQueryLogEvents.php
View file

@ -242,7 +242,7 @@ class ApiQueryLogEvents extends ApiQueryBase {
/** /**
* @deprecated since 1.25 Use LogFormatter::formatParametersForApi instead * @deprecated since 1.25 Use LogFormatter::formatParametersForApi instead
* @param ApiResult $result * @param ApiResult $result
* @param array $vals * @param array &$vals
* @param string $params * @param string $params
* @param string $type * @param string $type
* @param string $action * @param string $action

2
includes/cache/LinkBatch.php vendored
View file

@ -131,7 +131,7 @@ class LinkBatch {
* Do the query and add the results to a given LinkCache object * Do the query and add the results to a given LinkCache object
* Return an array mapping PDBK to ID * Return an array mapping PDBK to ID
* *
* @param LinkCache $cache * @param LinkCache &$cache
* @return array Remaining IDs * @return array Remaining IDs
*/ */
protected function executeInto( &$cache ) { protected function executeInto( &$cache ) {

2
includes/cache/MessageCache.php vendored
View file

@ -395,7 +395,7 @@ class MessageCache {
/** /**
* @param string $code * @param string $code
* @param array $where List of wfDebug() comments * @param array &$where List of wfDebug() comments
* @param integer $mode Use MessageCache::FOR_UPDATE to use DB_MASTER * @param integer $mode Use MessageCache::FOR_UPDATE to use DB_MASTER
* @return bool|string True on success or one of ("cantacquire", "disabled") * @return bool|string True on success or one of ("cantacquire", "disabled")
*/ */

8
includes/cache/localisation/LocalisationCache.php vendored
View file

@ -687,7 +687,7 @@ class LocalisationCache {
* exists, the data array is returned, otherwise false is returned. * exists, the data array is returned, otherwise false is returned.
* *
* @param string $code * @param string $code
* @param array $deps * @param array &$deps
* @return array * @return array
*/ */
protected function readSourceFilesAndRegisterDeps( $code, &$deps ) { protected function readSourceFilesAndRegisterDeps( $code, &$deps ) {
@ -719,7 +719,7 @@ class LocalisationCache {
* Merge two localisation values, a primary and a fallback, overwriting the * Merge two localisation values, a primary and a fallback, overwriting the
* primary value in place. * primary value in place.
* @param string $key * @param string $key
* @param mixed $value * @param mixed &$value
* @param mixed $fallbackValue * @param mixed $fallbackValue
*/ */
protected function mergeItem( $key, &$value, $fallbackValue ) { protected function mergeItem( $key, &$value, $fallbackValue ) {
@ -749,7 +749,7 @@ class LocalisationCache {
} }
/** /**
* @param mixed $value * @param mixed &$value
* @param mixed $fallbackValue * @param mixed $fallbackValue
*/ */
protected function mergeMagicWords( &$value, $fallbackValue ) { protected function mergeMagicWords( &$value, $fallbackValue ) {
@ -775,7 +775,7 @@ class LocalisationCache {
* otherwise. * otherwise.
* @param array $codeSequence * @param array $codeSequence
* @param string $key * @param string $key
* @param mixed $value * @param mixed &$value
* @param mixed $fallbackValue * @param mixed $fallbackValue
* @return bool * @return bool
*/ */

2
includes/changes/ChangesFeed.php
View file

@ -165,7 +165,7 @@ class ChangesFeed {
/** /**
* Generate the feed items given a row from the database, printing the feed. * Generate the feed items given a row from the database, printing the feed.
* @param object $rows IDatabase resource with recentchanges rows * @param object $rows IDatabase resource with recentchanges rows
* @param ChannelFeed $feed * @param ChannelFeed &$feed
*/ */
public static function generateFeed( $rows, &$feed ) { public static function generateFeed( $rows, &$feed ) {
$items = self::buildItems( $rows ); $items = self::buildItems( $rows );

28
includes/changes/ChangesList.php
View file

@ -102,7 +102,7 @@ class ChangesList extends ContextSource {
* *
* @since 1.27 * @since 1.27
* *
* @param RecentChange $rc Passed by reference * @param RecentChange &$rc Passed by reference
* @param bool $watched (default false) * @param bool $watched (default false)
* @param int $linenumber (default null) * @param int $linenumber (default null)
* *
@ -362,7 +362,7 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param string $s HTML to update * @param string &$s HTML to update
* @param mixed $rc_timestamp * @param mixed $rc_timestamp
*/ */
public function insertDateHeader( &$s, $rc_timestamp ) { public function insertDateHeader( &$s, $rc_timestamp ) {
@ -379,7 +379,7 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param string $s HTML to update * @param string &$s HTML to update
* @param Title $title * @param Title $title
* @param string $logtype * @param string $logtype
*/ */
@ -392,8 +392,8 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param string $s HTML to update * @param string &$s HTML to update
* @param RecentChange $rc * @param RecentChange &$rc
* @param bool|null $unpatrolled Unused variable, since 1.27. * @param bool|null $unpatrolled Unused variable, since 1.27.
*/ */
public function insertDiffHist( &$s, &$rc, $unpatrolled = null ) { public function insertDiffHist( &$s, &$rc, $unpatrolled = null ) {
@ -442,7 +442,7 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param string $s Article link will be appended to this string, in place. * @param string &$s Article link will be appended to this string, in place.
* @param RecentChange $rc * @param RecentChange $rc
* @param bool $unpatrolled * @param bool $unpatrolled
* @param bool $watched * @param bool $watched
@ -453,7 +453,7 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param RecentChange $rc * @param RecentChange &$rc
* @param bool $unpatrolled * @param bool $unpatrolled
* @param bool $watched * @param bool $watched
* @return string HTML * @return string HTML
@ -508,7 +508,7 @@ class ChangesList extends ContextSource {
/** /**
* Insert time timestamp string from $rc into $s * Insert time timestamp string from $rc into $s
* *
* @param string $s HTML to update * @param string &$s HTML to update
* @param RecentChange $rc * @param RecentChange $rc
*/ */
public function insertTimestamp( &$s, $rc ) { public function insertTimestamp( &$s, $rc ) {
@ -620,8 +620,8 @@ class ChangesList extends ContextSource {
/** Inserts a rollback link /** Inserts a rollback link
* *
* @param string $s * @param string &$s
* @param RecentChange $rc * @param RecentChange &$rc
*/ */
public function insertRollback( &$s, &$rc ) { public function insertRollback( &$s, &$rc ) {
if ( $rc->mAttribs['rc_type'] == RC_EDIT if ( $rc->mAttribs['rc_type'] == RC_EDIT
@ -658,9 +658,9 @@ class ChangesList extends ContextSource {
} }
/** /**
* @param string $s * @param string &$s
* @param RecentChange $rc * @param RecentChange &$rc
* @param array $classes * @param array &$classes
*/ */
public function insertTags( &$s, &$rc, &$classes ) { public function insertTags( &$s, &$rc, &$classes ) {
if ( empty( $rc->mAttribs['ts_tags'] ) ) { if ( empty( $rc->mAttribs['ts_tags'] ) ) {
@ -678,7 +678,7 @@ class ChangesList extends ContextSource {
/** /**
* @param RecentChange $rc * @param RecentChange $rc
* @param array $classes * @param array &$classes
* @return string * @return string
* @since 1.26 * @since 1.26
*/ */

2
includes/changes/EnhancedChangesList.php
View file

@ -91,7 +91,7 @@ class EnhancedChangesList extends ChangesList {
/** /**
* Format a line for enhanced recentchange (aka with javascript and block of lines). * Format a line for enhanced recentchange (aka with javascript and block of lines).
* *
* @param RecentChange $rc * @param RecentChange &$rc
* @param bool $watched * @param bool $watched
* @param int $linenumber (default null) * @param int $linenumber (default null)
* *

2
includes/changes/OldChangesList.php
View file

@ -25,7 +25,7 @@ class OldChangesList extends ChangesList {
/** /**
* Format a line using the old system (aka without any javascript). * Format a line using the old system (aka without any javascript).
* *
* @param RecentChange $rc Passed by reference * @param RecentChange &$rc Passed by reference
* @param bool $watched (default false) * @param bool $watched (default false)
* @param int $linenumber (default null) * @param int $linenumber (default null)
* *

16
includes/changes/RecentChange.php
View file

@ -552,9 +552,9 @@ class RecentChange {
* Makes an entry in the database corresponding to an edit * Makes an entry in the database corresponding to an edit
* *
* @param string $timestamp * @param string $timestamp
* @param Title $title * @param Title &$title
* @param bool $minor * @param bool $minor
* @param User $user * @param User &$user
* @param string $comment * @param string $comment
* @param int $oldId * @param int $oldId
* @param string $lastTimestamp * @param string $lastTimestamp
@ -629,9 +629,9 @@ class RecentChange {
* Note: the title object must be loaded with the new id using resetArticleID() * Note: the title object must be loaded with the new id using resetArticleID()
* *
* @param string $timestamp * @param string $timestamp
* @param Title $title * @param Title &$title
* @param bool $minor * @param bool $minor
* @param User $user * @param User &$user
* @param string $comment * @param string $comment
* @param bool $bot * @param bool $bot
* @param string $ip * @param string $ip
@ -699,8 +699,8 @@ class RecentChange {
/** /**
* @param string $timestamp * @param string $timestamp
* @param Title $title * @param Title &$title
* @param User $user * @param User &$user
* @param string $actionComment * @param string $actionComment
* @param string $ip * @param string $ip
* @param string $type * @param string $type
@ -730,8 +730,8 @@ class RecentChange {
/** /**
* @param string $timestamp * @param string $timestamp
* @param Title $title * @param Title &$title
* @param User $user * @param User &$user
* @param string $actionComment * @param string $actionComment
* @param string $ip * @param string $ip
* @param string $type * @param string $type

10
includes/changetags/ChangeTags.php
View file

@ -649,11 +649,11 @@ class ChangeTags {
* if you had ORDER BY foo_timestamp DESC, you will now need GROUP BY foo_timestamp, foo_id * if you had ORDER BY foo_timestamp DESC, you will now need GROUP BY foo_timestamp, foo_id
* ORDER BY foo_timestamp DESC, foo_id DESC. * ORDER BY foo_timestamp DESC, foo_id DESC.
* *
* @param string|array $tables Table names, see Database::select * @param string|array &$tables Table names, see Database::select
* @param string|array $fields Fields used in query, see Database::select * @param string|array &$fields Fields used in query, see Database::select
* @param string|array $conds Conditions used in query, see Database::select * @param string|array &$conds Conditions used in query, see Database::select
* @param array $join_conds Join conditions, see Database::select * @param array &$join_conds Join conditions, see Database::select
* @param string|array $options Options, see Database::select * @param string|array &$options Options, see Database::select
* @param string|array $filter_tag Tag(s) to select on * @param string|array $filter_tag Tag(s) to select on
* *
* @throws MWException When unable to determine appropriate JOIN condition for tagging * @throws MWException When unable to determine appropriate JOIN condition for tagging

2
includes/compat/normal/UtfNormal.php
View file

@ -120,7 +120,7 @@ class UtfNormal {
/** /**
* Returns true if the string is _definitely_ in NFC. * Returns true if the string is _definitely_ in NFC.
* Returns false if not or uncertain. * Returns false if not or uncertain.
* @param string $string a UTF-8 string, altered on output to be valid UTF-8 safe for XML. * @param string &$string a UTF-8 string, altered on output to be valid UTF-8 safe for XML.
* @return bool * @return bool
*/ */
static function quickIsNFCVerify( &$string ) { static function quickIsNFCVerify( &$string ) {

2
includes/content/ContentHandler.php
View file

@ -1134,7 +1134,7 @@ abstract class ContentHandler {
/** /**
* Add new field definition to array. * Add new field definition to array.
* @param SearchIndexField[] $fields * @param SearchIndexField[] &$fields
* @param SearchEngine $engine * @param SearchEngine $engine
* @param string $name * @param string $name
* @param int $type * @param int $type

2
includes/content/JsonContent.php
View file

@ -96,7 +96,7 @@ class JsonContent extends TextContent {
* @param int $revId * @param int $revId
* @param ParserOptions $options * @param ParserOptions $options
* @param bool $generateHtml * @param bool $generateHtml
* @param ParserOutput $output * @param ParserOutput &$output
*/ */
protected function fillParserOutput( Title $title, $revId, protected function fillParserOutput( Title $title, $revId,
ParserOptions $options, $generateHtml, ParserOutput &$output ParserOptions $options, $generateHtml, ParserOutput &$output

2
includes/content/TextContent.php
View file

@ -233,7 +233,7 @@ class TextContent extends AbstractContent {
* @param int $revId Revision ID (for {{REVISIONID}}) * @param int $revId Revision ID (for {{REVISIONID}})
* @param ParserOptions $options Parser options * @param ParserOptions $options Parser options
* @param bool $generateHtml Whether or not to generate HTML * @param bool $generateHtml Whether or not to generate HTML
* @param ParserOutput $output The output object to fill (reference). * @param ParserOutput &$output The output object to fill (reference).
*/ */
protected function fillParserOutput( Title $title, $revId, protected function fillParserOutput( Title $title, $revId,
ParserOptions $options, $generateHtml, ParserOutput &$output ParserOptions $options, $generateHtml, ParserOutput &$output

2
includes/db/ORAResult.php
View file

@ -31,7 +31,7 @@ class ORAResult {
} }
/** /**
* @param IDatabase $db * @param IDatabase &$db
* @param resource $stmt A valid OCI statement identifier * @param resource $stmt A valid OCI statement identifier
* @param bool $unique * @param bool $unique
*/ */

2
includes/deferred/SiteStatsUpdate.php
View file

@ -189,7 +189,7 @@ class SiteStatsUpdate implements DeferrableUpdate, MergeableUpdate {
} }
/** /**
* @param string $sql * @param string &$sql
* @param string $field * @param string $field
* @param int $delta * @param int $delta
*/ */

2
includes/diff/DiffFormatter.php
View file

@ -125,7 +125,7 @@ abstract class DiffFormatter {
* @param int $xlen * @param int $xlen
* @param int $ybeg * @param int $ybeg
* @param int $ylen * @param int $ylen
* @param array $edits * @param array &$edits
* *
* @throws MWException If the edit type is not known. * @throws MWException If the edit type is not known.
*/ */

2
includes/export/DumpFilter.php
View file

@ -42,7 +42,7 @@ class DumpFilter {
protected $sendingThisPage; protected $sendingThisPage;
/** /**
* @param DumpOutput $sink * @param DumpOutput &$sink
*/ */
function __construct( &$sink ) { function __construct( &$sink ) {
$this->sink =& $sink; $this->sink =& $sink;

2
includes/export/DumpNamespaceFilter.php
View file

@ -34,7 +34,7 @@ class DumpNamespaceFilter extends DumpFilter {
public $namespaces = []; public $namespaces = [];
/** /**
* @param DumpOutput $sink * @param DumpOutput &$sink
* @param array $param * @param array $param
* @throws MWException * @throws MWException
*/ */

2
includes/export/WikiExporter.php
View file

@ -106,7 +106,7 @@ class WikiExporter {
* various row objects and XML output for filtering. Filters * various row objects and XML output for filtering. Filters
* can be chained or used as callbacks. * can be chained or used as callbacks.
* *
* @param DumpOutput $sink * @param DumpOutput &$sink
*/ */
public function setOutputSink( &$sink ) { public function setOutputSink( &$sink ) {
$this->sink =& $sink; $this->sink =& $sink;

2
includes/gallery/TraditionalImageGallery.php
View file

@ -348,7 +348,7 @@ class TraditionalImageGallery extends ImageGalleryBase {
* *
* Used by a subclass to insert extra high resolution images. * Used by a subclass to insert extra high resolution images.
* @param MediaTransformOutput $thumb The thumbnail * @param MediaTransformOutput $thumb The thumbnail
* @param array $imageParameters Array of options * @param array &$imageParameters Array of options
*/ */
protected function adjustImageParameters( $thumb, &$imageParameters ) { protected function adjustImageParameters( $thumb, &$imageParameters ) {
} }

2
includes/htmlform/HTMLForm.php
View file

@ -450,7 +450,7 @@ class HTMLForm extends ContextSource {
* @since 1.23 * @since 1.23
* *
* @param string $fieldname Name of the field * @param string $fieldname Name of the field
* @param array $descriptor Input Descriptor, as described above * @param array &$descriptor Input Descriptor, as described above
* *
* @throws MWException * @throws MWException
* @return string Name of a HTMLFormField subclass * @return string Name of a HTMLFormField subclass

2
includes/import/UploadSourceAdapter.php
View file

@ -57,7 +57,7 @@ class UploadSourceAdapter {
* @param string $path * @param string $path
* @param string $mode * @param string $mode
* @param array $options * @param array $options
* @param string $opened_path * @param string &$opened_path
* @return bool * @return bool
*/ */
function stream_open( $path, $mode, $options, &$opened_path ) { function stream_open( $path, $mode, $options, &$opened_path ) {

2
includes/import/WikiImporter.php
View file

@ -428,7 +428,7 @@ class WikiImporter {
/** /**
* Alternate per-revision callback, for debugging. * Alternate per-revision callback, for debugging.
* @param WikiRevision $revision * @param WikiRevision &$revision
*/ */
public function debugRevisionHandler( &$revision ) { public function debugRevisionHandler( &$revision ) {
$this->debug( "Got revision:" ); $this->debug( "Got revision:" );

2
includes/installer/DatabaseUpdater.php
View file

@ -106,7 +106,7 @@ abstract class DatabaseUpdater {
protected $holdContentHandlerUseDB = true; protected $holdContentHandlerUseDB = true;
/** /**
* @param Database $db To perform updates on * @param Database &$db To perform updates on
* @param bool $shared Whether to perform updates on shared tables * @param bool $shared Whether to perform updates on shared tables
* @param Maintenance $maintenance Maintenance object which created us * @param Maintenance $maintenance Maintenance object which created us
*/ */

2
includes/installer/SqliteInstaller.php
View file

@ -296,7 +296,7 @@ EOT;
} }
/** /**
* @param Status $status * @param Status &$status
* @return Status * @return Status
*/ */
public function setupSearchIndex( &$status ) { public function setupSearchIndex( &$status ) {

2
includes/jobqueue/JobQueueFederated.php
View file

@ -202,7 +202,7 @@ class JobQueueFederated extends JobQueue {
/** /**
* @param array $jobs * @param array $jobs
* @param HashRing $partitionRing * @param HashRing &$partitionRing
* @param int $flags * @param int $flags
* @throws JobQueueError * @throws JobQueueError
* @return array List of Job object that could not be inserted * @return array List of Job object that could not be inserted

2
includes/libs/ArrayUtils.php
View file

@ -39,7 +39,7 @@ class ArrayUtils {
* justification for breaking compatibility with installations * justification for breaking compatibility with installations
* compiled with ./configure --disable-hash. * compiled with ./configure --disable-hash.
* *
* @param array $array Array to sort * @param array &$array Array to sort
* @param string $key * @param string $key
* @param string $separator A separator used to delimit the array elements and the * @param string $separator A separator used to delimit the array elements and the
* key. This can be chosen to provide backwards compatibility with * key. This can be chosen to provide backwards compatibility with

2
includes/libs/MultiHttpClient.php
View file

@ -275,7 +275,7 @@ class MultiHttpClient implements LoggerAwareInterface {
} }
/** /**
* @param array $req HTTP request map * @param array &$req HTTP request map
* @param array $opts * @param array $opts
* - connTimeout : default connection timeout * - connTimeout : default connection timeout
* - reqTimeout : default request timeout * - reqTimeout : default request timeout

6
includes/libs/filebackend/SwiftFileBackend.php
View file

@ -828,7 +828,7 @@ class SwiftFileBackend extends FileBackendStore {
* *
* @param string $fullCont Resolved container name * @param string $fullCont Resolved container name
* @param string $dir Resolved storage directory with no trailing slash * @param string $dir Resolved storage directory with no trailing slash
* @param string|null $after Resolved container relative path to list items after * @param string|null &$after Resolved container relative path to list items after
* @param int $limit Max number of items to list * @param int $limit Max number of items to list
* @param array $params Parameters for getDirectoryList() * @param array $params Parameters for getDirectoryList()
* @return array List of container relative resolved paths of directories directly under $dir * @return array List of container relative resolved paths of directories directly under $dir
@ -908,7 +908,7 @@ class SwiftFileBackend extends FileBackendStore {
* *
* @param string $fullCont Resolved container name * @param string $fullCont Resolved container name
* @param string $dir Resolved storage directory with no trailing slash * @param string $dir Resolved storage directory with no trailing slash
* @param string|null $after Resolved container relative path of file to list items after * @param string|null &$after Resolved container relative path of file to list items after
* @param int $limit Max number of items to list * @param int $limit Max number of items to list
* @param array $params Parameters for getDirectoryList() * @param array $params Parameters for getDirectoryList()
* @return array List of resolved container relative paths of files under $dir * @return array List of resolved container relative paths of files under $dir
@ -1888,7 +1888,7 @@ abstract class SwiftFileBackendList implements Iterator {
* *
* @param string $container Resolved container name * @param string $container Resolved container name
* @param string $dir Resolved path relative to container * @param string $dir Resolved path relative to container
* @param string $after * @param string &$after
* @param int $limit * @param int $limit
* @param array $params * @param array $params
* @return Traversable|array * @return Traversable|array

4
includes/libs/filebackend/fileop/FileOp.php
View file

@ -247,7 +247,7 @@ abstract class FileOp {
* This must update $predicates for each path that the op can change * This must update $predicates for each path that the op can change
* except when a failing StatusValue object is returned. * except when a failing StatusValue object is returned.
* *
* @param array $predicates * @param array &$predicates
* @return StatusValue * @return StatusValue
*/ */
final public function precheck( array &$predicates ) { final public function precheck( array &$predicates ) {
@ -264,7 +264,7 @@ abstract class FileOp {
} }
/** /**
* @param array $predicates * @param array &$predicates
* @return StatusValue * @return StatusValue
*/ */
protected function doPrecheck( array &$predicates ) { protected function doPrecheck( array &$predicates ) {

2
includes/libs/lockmanager/ScopedLock.php
View file

@ -85,7 +85,7 @@ class ScopedLock {
* This is useful for early release of locks before function scope is destroyed. * This is useful for early release of locks before function scope is destroyed.
* This is the same as setting the lock object to null. * This is the same as setting the lock object to null.
* *
* @param ScopedLock $lock * @param ScopedLock &$lock
* @since 1.21 * @since 1.21
*/ */
public static function release( ScopedLock &$lock = null ) { public static function release( ScopedLock &$lock = null ) {

2
includes/libs/objectcache/BagOStuff.php
View file

@ -229,7 +229,7 @@ abstract class BagOStuff implements IExpiringStore, LoggerAwareInterface {
* @note: This method is only needed if merge() uses mergeViaCas() * @note: This method is only needed if merge() uses mergeViaCas()
* *
* @param string $key * @param string $key
* @param mixed $casToken * @param mixed &$casToken
* @param integer $flags Bitfield of BagOStuff::READ_* constants [optional] * @param integer $flags Bitfield of BagOStuff::READ_* constants [optional]
* @return mixed Returns false on failure and if the item does not exist * @return mixed Returns false on failure and if the item does not exist
* @throws Exception * @throws Exception

4
includes/libs/objectcache/WANObjectCache.php
View file

@ -240,7 +240,7 @@ class WANObjectCache implements IExpiringStore, LoggerAwareInterface {
* That method has cache slam avoiding features for hot/expensive keys. * That method has cache slam avoiding features for hot/expensive keys.
* *
* @param string $key Cache key * @param string $key Cache key
* @param mixed $curTTL Approximate TTL left on the key if present/tombstoned [returned] * @param mixed &$curTTL Approximate TTL left on the key if present/tombstoned [returned]
* @param array $checkKeys List of "check" keys * @param array $checkKeys List of "check" keys
* @param float &$asOf UNIX timestamp of cached value; null on failure [returned] * @param float &$asOf UNIX timestamp of cached value; null on failure [returned]
* @return mixed Value of cache key or false on failure * @return mixed Value of cache key or false on failure
@ -261,7 +261,7 @@ class WANObjectCache implements IExpiringStore, LoggerAwareInterface {
* @see WANObjectCache::get() * @see WANObjectCache::get()
* *
* @param array $keys List of cache keys * @param array $keys List of cache keys
* @param array $curTTLs Map of (key => approximate TTL left) for existing keys [returned] * @param array &$curTTLs Map of (key => approximate TTL left) for existing keys [returned]
* @param array $checkKeys List of check keys to apply to all $keys. May also apply "check" * @param array $checkKeys List of check keys to apply to all $keys. May also apply "check"
* keys to specific cache keys only by using cache keys as keys in the $checkKeys array. * keys to specific cache keys only by using cache keys as keys in the $checkKeys array.
* @param float[] &$asOfs Map of (key => UNIX timestamp of cached value; null on failure) * @param float[] &$asOfs Map of (key => UNIX timestamp of cached value; null on failure)

4
includes/libs/rdbms/database/DatabaseMysqlBase.php
View file

@ -989,8 +989,8 @@ abstract class DatabaseMysqlBase extends Database {
} }
/** /**
* @param string $sql * @param string &$sql
* @param string $newLine * @param string &$newLine
* @return bool * @return bool
*/ */
public function streamStatementEnd( &$sql, &$newLine ) { public function streamStatementEnd( &$sql, &$newLine ) {

2
includes/logging/LogEventsList.php
View file

@ -569,7 +569,7 @@ class LogEventsList extends ContextSource {
/** /**
* Show log extract. Either with text and a box (set $msgKey) or without (don't set $msgKey) * Show log extract. Either with text and a box (set $msgKey) or without (don't set $msgKey)
* *
* @param OutputPage|string $out By-reference * @param OutputPage|string &$out
* @param string|array $types Log types to show * @param string|array $types Log types to show
* @param string|Title $page The page title to show log entries for * @param string|Title $page The page title to show log entries for
* @param string $user The user who made the log entries * @param string $user The user who made the log entries

2
includes/logging/LogPage.php
View file

@ -287,7 +287,7 @@ class LogPage {
* @param string $type * @param string $type
* @param Language|null $lang * @param Language|null $lang
* @param Title $title * @param Title $title
* @param array $params * @param array &$params
* @return string * @return string
*/ */
protected static function getTitleLink( $type, $lang, $title, &$params ) { protected static function getTitleLink( $type, $lang, $title, &$params ) {

2
includes/media/Bitmap.php
View file

@ -88,7 +88,7 @@ class BitmapHandler extends TransformationalImageHandler {
/** /**
* @param File $image * @param File $image
* @param array $params * @param array &$params
* @return bool * @return bool
*/ */
function normaliseParams( $image, &$params ) { function normaliseParams( $image, &$params ) {

2
includes/media/Bitmap_ClientOnly.php
View file

@ -35,7 +35,7 @@ class BitmapHandler_ClientOnly extends BitmapHandler {
/** /**
* @param File $image * @param File $image
* @param array $params * @param array &$params
* @return bool * @return bool
*/ */
function normaliseParams( $image, &$params ) { function normaliseParams( $image, &$params ) {

8
includes/media/FormatMetadata.php
View file

@ -1675,7 +1675,7 @@ class FormatMetadata extends ContextSource {
* *
* @param File $file File to use * @param File $file File to use
* @param array $extendedMetadata * @param array $extendedMetadata
* @param int $maxCacheTime Hook handlers might use this parameter to override cache time * @param int &$maxCacheTime Hook handlers might use this parameter to override cache time
* *
* @return array [<property name> => ['value' => <value>]], or [] on error * @return array [<property name> => ['value' => <value>]], or [] on error
* @since 1.23 * @since 1.23
@ -1772,7 +1772,7 @@ class FormatMetadata extends ContextSource {
/** /**
* Takes an array returned by the getExtendedMetadata* functions, * Takes an array returned by the getExtendedMetadata* functions,
* and resolves multi-language values in it. * and resolves multi-language values in it.
* @param array $metadata * @param array &$metadata
* @since 1.23 * @since 1.23
*/ */
protected function resolveMultilangMetadata( &$metadata ) { protected function resolveMultilangMetadata( &$metadata ) {
@ -1789,7 +1789,7 @@ class FormatMetadata extends ContextSource {
/** /**
* Takes an array returned by the getExtendedMetadata* functions, * Takes an array returned by the getExtendedMetadata* functions,
* and turns all fields into single-valued ones by dropping extra values. * and turns all fields into single-valued ones by dropping extra values.
* @param array $metadata * @param array &$metadata
* @since 1.25 * @since 1.25
*/ */
protected function discardMultipleValues( &$metadata ) { protected function discardMultipleValues( &$metadata ) {
@ -1810,7 +1810,7 @@ class FormatMetadata extends ContextSource {
/** /**
* Makes sure the given array is a valid API response fragment * Makes sure the given array is a valid API response fragment
* @param array $arr * @param array &$arr
*/ */
protected function sanitizeArrayForAPI( &$arr ) { protected function sanitizeArrayForAPI( &$arr ) {
if ( !is_array( $arr ) ) { if ( !is_array( $arr ) ) {

6
includes/media/ImageHandler.php
View file

@ -80,7 +80,7 @@ abstract class ImageHandler extends MediaHandler {
/** /**
* @param File $image * @param File $image
* @param array $params * @param array &$params
* @return bool * @return bool
*/ */
function normaliseParams( $image, &$params ) { function normaliseParams( $image, &$params ) {
@ -152,8 +152,8 @@ abstract class ImageHandler extends MediaHandler {
/** /**
* Validate thumbnail parameters and fill in the correct height * Validate thumbnail parameters and fill in the correct height
* *
* @param int $width Specified width (input/output) * @param int &$width Specified width (input/output)
* @param int $height Height (output only) * @param int &$height Height (output only)
* @param int $srcWidth Width of the source image * @param int $srcWidth Width of the source image
* @param int $srcHeight Height of the source image * @param int $srcHeight Height of the source image
* @param string $mimeType Unused * @param string $mimeType Unused

4
includes/media/MediaHandler.php
View file

@ -85,7 +85,7 @@ abstract class MediaHandler {
* Should be idempotent. * Should be idempotent.
* Returns false if the parameters are unacceptable and the transform should fail * Returns false if the parameters are unacceptable and the transform should fail
* @param File $image * @param File $image
* @param array $params * @param array &$params
*/ */
abstract function normaliseParams( $image, &$params ); abstract function normaliseParams( $image, &$params );
@ -712,7 +712,7 @@ abstract class MediaHandler {
* *
* @see LocalFile::purgeThumbnails * @see LocalFile::purgeThumbnails
* *
* @param array $files * @param array &$files
* @param array $options Purge options. Currently will always be * @param array $options Purge options. Currently will always be
* an array with a single key 'forThumbRefresh' set to true. * an array with a single key 'forThumbRefresh' set to true.
*/ */

2
includes/media/SVG.php
View file

@ -126,7 +126,7 @@ class SvgHandler extends ImageHandler {
/** /**
* @param File $image * @param File $image
* @param array $params * @param array &$params
* @return bool * @return bool
*/ */
function normaliseParams( $image, &$params ) { function normaliseParams( $image, &$params ) {

4
includes/media/TransformationalImageHandler.php
View file

@ -36,7 +36,7 @@ use MediaWiki\MediaWikiServices;
abstract class TransformationalImageHandler extends ImageHandler { abstract class TransformationalImageHandler extends ImageHandler {
/** /**
* @param File $image * @param File $image
* @param array $params Transform parameters. Entries with the keys 'width' * @param array &$params Transform parameters. Entries with the keys 'width'
* and 'height' are the respective screen width and height, while the keys * and 'height' are the respective screen width and height, while the keys
* 'physicalWidth' and 'physicalHeight' indicate the thumbnail dimensions. * 'physicalWidth' and 'physicalHeight' indicate the thumbnail dimensions.
* @return bool * @return bool
@ -588,7 +588,7 @@ abstract class TransformationalImageHandler extends ImageHandler {
* Runs the 'BitmapHandlerCheckImageArea' hook. * Runs the 'BitmapHandlerCheckImageArea' hook.
* *
* @param File $file * @param File $file
* @param array $params * @param array &$params
* @return bool * @return bool
* @since 1.25 * @since 1.25
*/ */

2
includes/objectcache/SqlBagOStuff.php
View file

@ -672,7 +672,7 @@ class SqlBagOStuff extends BagOStuff {
* On typical message and page data, this can provide a 3X decrease * On typical message and page data, this can provide a 3X decrease
* in storage requirements. * in storage requirements.
* *
* @param mixed $data * @param mixed &$data
* @return string * @return string
*/ */
protected function serialize( &$data ) { protected function serialize( &$data ) {

12
includes/page/Article.php
View file

@ -2580,7 +2580,7 @@ class Article implements Page {
/** /**
* @param array $limit * @param array $limit
* @param array $expiry * @param array $expiry
* @param bool $cascade * @param bool &$cascade
* @param string $reason * @param string $reason
* @param User $user * @param User $user
* @return Status * @return Status
@ -2594,7 +2594,7 @@ class Article implements Page {
/** /**
* @param array $limit * @param array $limit
* @param string $reason * @param string $reason
* @param int $cascade * @param int &$cascade
* @param array $expiry * @param array $expiry
* @return bool * @return bool
*/ */
@ -2615,7 +2615,7 @@ class Article implements Page {
* @param bool $suppress * @param bool $suppress
* @param int $u1 Unused * @param int $u1 Unused
* @param bool $u2 Unused * @param bool $u2 Unused
* @param string $error * @param string &$error
* @return bool * @return bool
*/ */
public function doDeleteArticle( public function doDeleteArticle(
@ -2629,7 +2629,7 @@ class Article implements Page {
* @param string $summary * @param string $summary
* @param string $token * @param string $token
* @param bool $bot * @param bool $bot
* @param array $resultDetails * @param array &$resultDetails
* @param User|null $user * @param User|null $user
* @return array * @return array
*/ */
@ -2642,7 +2642,7 @@ class Article implements Page {
* @param string $fromP * @param string $fromP
* @param string $summary * @param string $summary
* @param bool $bot * @param bool $bot
* @param array $resultDetails * @param array &$resultDetails
* @param User|null $guser * @param User|null $guser
* @return array * @return array
*/ */
@ -2652,7 +2652,7 @@ class Article implements Page {
} }
/** /**
* @param bool $hasHistory * @param bool &$hasHistory
* @return mixed * @return mixed
*/ */
public function generateReason( &$hasHistory ) { public function generateReason( &$hasHistory ) {

4
includes/page/WikiPage.php
View file

@ -3001,7 +3001,7 @@ class WikiPage implements Page, IDBAccessObject {
* @param string $token Rollback token. * @param string $token Rollback token.
* @param bool $bot If true, mark all reverted edits as bot. * @param bool $bot If true, mark all reverted edits as bot.
* *
* @param array $resultDetails Array contains result-specific array of additional values * @param array &$resultDetails Array contains result-specific array of additional values
* 'alreadyrolled' : 'current' (rev) * 'alreadyrolled' : 'current' (rev)
* success : 'summary' (str), 'current' (rev), 'target' (rev) * success : 'summary' (str), 'current' (rev), 'target' (rev)
* *
@ -3053,7 +3053,7 @@ class WikiPage implements Page, IDBAccessObject {
* @param string $summary Custom summary. Set to default summary if empty. * @param string $summary Custom summary. Set to default summary if empty.
* @param bool $bot If true, mark all reverted edits as bot. * @param bool $bot If true, mark all reverted edits as bot.
* *
* @param array $resultDetails Contains result-specific array of additional values * @param array &$resultDetails Contains result-specific array of additional values
* @param User $guser The user performing the rollback * @param User $guser The user performing the rollback
* @param array|null $tags Change tags to apply to the rollback * @param array|null $tags Change tags to apply to the rollback
* Callers are responsible for permission checks * Callers are responsible for permission checks

8
includes/parser/LinkHolderArray.php
View file

@ -264,7 +264,7 @@ class LinkHolderArray {
/** /**
* Replace <!--LINK--> link placeholders with actual links, in the buffer * Replace <!--LINK--> link placeholders with actual links, in the buffer
* *
* @param string $text * @param string &$text
*/ */
public function replace( &$text ) { public function replace( &$text ) {
$this->replaceInternal( $text ); $this->replaceInternal( $text );
@ -273,7 +273,7 @@ class LinkHolderArray {
/** /**
* Replace internal links * Replace internal links
* @param string $text * @param string &$text
*/ */
protected function replaceInternal( &$text ) { protected function replaceInternal( &$text ) {
if ( !$this->internals ) { if ( !$this->internals ) {
@ -416,7 +416,7 @@ class LinkHolderArray {
/** /**
* Replace interwiki links * Replace interwiki links
* @param string $text * @param string &$text
*/ */
protected function replaceInterwiki( &$text ) { protected function replaceInterwiki( &$text ) {
if ( empty( $this->interwikis ) ) { if ( empty( $this->interwikis ) ) {
@ -444,7 +444,7 @@ class LinkHolderArray {
/** /**
* Modify $this->internals and $colours according to language variant linking rules * Modify $this->internals and $colours according to language variant linking rules
* @param array $colours * @param array &$colours
*/ */
protected function doVariants( &$colours ) { protected function doVariants( &$colours ) {
global $wgContLang; global $wgContLang;

10
includes/parser/Parser.php
View file

@ -972,7 +972,7 @@ class Parser {
* *
* @param array $elements List of element names. Comments are always extracted. * @param array $elements List of element names. Comments are always extracted.
* @param string $text Source text string. * @param string $text Source text string.
* @param array $matches Out parameter, Array: extracted tags * @param array &$matches Out parameter, Array: extracted tags
* @param string|null $uniq_prefix * @param string|null $uniq_prefix
* @return string Stripped text * @return string Stripped text
* @since 1.26 The uniq_prefix argument is deprecated. * @since 1.26 The uniq_prefix argument is deprecated.
@ -2103,7 +2103,7 @@ class Parser {
/** /**
* Process [[ ]] wikilinks (RIL) * Process [[ ]] wikilinks (RIL)
* @param string $s * @param string &$s
* @throws MWException * @throws MWException
* @return LinkHolderArray * @return LinkHolderArray
* *
@ -4536,7 +4536,7 @@ class Parser {
* Do not reuse this parser instance after calling getUserSig(), * Do not reuse this parser instance after calling getUserSig(),
* as it may have changed if it's the $wgParser. * as it may have changed if it's the $wgParser.
* *
* @param User $user * @param User &$user
* @param string|bool $nickname Nickname to use or false to use user's default nickname * @param string|bool $nickname Nickname to use or false to use user's default nickname
* @param bool|null $fancySig whether the nicknname is the complete signature * @param bool|null $fancySig whether the nicknname is the complete signature
* or null to use default value * or null to use default value
@ -4897,7 +4897,7 @@ class Parser {
* Replace "<!--LINK-->" link placeholders with actual links, in the buffer * Replace "<!--LINK-->" link placeholders with actual links, in the buffer
* Placeholders created in Linker::link() * Placeholders created in Linker::link()
* *
* @param string $text * @param string &$text
* @param int $options * @param int $options
*/ */
public function replaceLinkHolders( &$text, $options = 0 ) { public function replaceLinkHolders( &$text, $options = 0 ) {
@ -5406,7 +5406,7 @@ class Parser {
* Callback from the Sanitizer for expanding items found in HTML attribute * Callback from the Sanitizer for expanding items found in HTML attribute
* values, so they can be safely tested and escaped. * values, so they can be safely tested and escaped.
* *
* @param string $text * @param string &$text
* @param bool|PPFrame $frame * @param bool|PPFrame $frame
* @return string * @return string
*/ */

2
includes/profiler/Profiler.php
View file

@ -164,7 +164,7 @@ abstract class Profiler {
abstract public function scopedProfileIn( $section ); abstract public function scopedProfileIn( $section );
/** /**
* @param SectionProfileCallback $section * @param SectionProfileCallback &$section
*/ */
public function scopedProfileOut( SectionProfileCallback &$section = null ) { public function scopedProfileOut( SectionProfileCallback &$section = null ) {
$section = null; $section = null;

2
includes/profiler/SectionProfiler.php
View file

@ -66,7 +66,7 @@ class SectionProfiler {
} }
/** /**
* @param ScopedCallback $section * @param ScopedCallback &$section
*/ */
public function scopedProfileOut( ScopedCallback &$section ) { public function scopedProfileOut( ScopedCallback &$section ) {
$section = null; $section = null;

2
includes/revisiondelete/RevisionDeleter.php
View file

@ -98,7 +98,7 @@ class RevisionDeleter {
* @param int $field The bitmask describing the single option. * @param int $field The bitmask describing the single option.
* @param int $diff The xor of the old and new bitfields. * @param int $diff The xor of the old and new bitfields.
* @param int $new The new bitfield * @param int $new The new bitfield
* @param array $arr The array to update. * @param array &$arr The array to update.
*/ */
protected static function checkItem( $desc, $field, $diff, $new, &$arr ) { protected static function checkItem( $desc, $field, $diff, $new, &$arr ) {
if ( $diff & $field ) { if ( $diff & $field ) {

16
includes/search/SearchHighlighter.php
View file

@ -291,8 +291,8 @@ class SearchHighlighter {
/** /**
* Split text into lines and add it to extracts array * Split text into lines and add it to extracts array
* *
* @param array $extracts Index -> $line * @param array &$extracts Index -> $line
* @param int $count * @param int &$count
* @param string $text * @param string $text
*/ */
function splitAndAdd( &$extracts, &$count, $text ) { function splitAndAdd( &$extracts, &$count, $text ) {
@ -326,8 +326,8 @@ class SearchHighlighter {
* @param string $text * @param string $text
* @param int $start * @param int $start
* @param int $end * @param int $end
* @param int $posStart (out) actual start position * @param int &$posStart (out) actual start position
* @param int $posEnd (out) actual end position * @param int &$posEnd (out) actual end position
* @return string * @return string
*/ */
function extract( $text, $start, $end, &$posStart = null, &$posEnd = null ) { function extract( $text, $start, $end, &$posStart = null, &$posEnd = null ) {
@ -397,10 +397,10 @@ class SearchHighlighter {
* *
* @param string $pattern Regexp for matching lines * @param string $pattern Regexp for matching lines
* @param array $extracts Extracts to search * @param array $extracts Extracts to search
* @param int $linesleft Number of extracts to make * @param int &$linesleft Number of extracts to make
* @param int $contextchars Length of snippet * @param int &$contextchars Length of snippet
* @param array $out Map for highlighted snippets * @param array &$out Map for highlighted snippets
* @param array $offsets Map of starting points of snippets * @param array &$offsets Map of starting points of snippets
* @protected * @protected
*/ */
function process( $pattern, $extracts, &$linesleft, &$contextchars, &$out, &$offsets ) { function process( $pattern, $extracts, &$linesleft, &$contextchars, &$out, &$offsets ) {

6
includes/search/SearchMySQL.php
View file

@ -218,7 +218,7 @@ class SearchMySQL extends SearchDatabase {
/** /**
* Add special conditions * Add special conditions
* @param array $query * @param array &$query
* @since 1.18 * @since 1.18
*/ */
protected function queryFeatures( &$query ) { protected function queryFeatures( &$query ) {
@ -231,7 +231,7 @@ class SearchMySQL extends SearchDatabase {
/** /**
* Add namespace conditions * Add namespace conditions
* @param array $query * @param array &$query
* @since 1.18 (changed) * @since 1.18 (changed)
*/ */
function queryNamespaces( &$query ) { function queryNamespaces( &$query ) {
@ -245,7 +245,7 @@ class SearchMySQL extends SearchDatabase {
/** /**
* Add limit options * Add limit options
* @param array $query * @param array &$query
* @since 1.18 * @since 1.18
*/ */
protected function limitResult( &$query ) { protected function limitResult( &$query ) {

4
includes/skins/QuickTemplate.php
View file

@ -92,14 +92,14 @@ abstract class QuickTemplate {
/** /**
* @param string $name * @param string $name
* @param mixed $value * @param mixed &$value
*/ */
public function setRef( $name, &$value ) { public function setRef( $name, &$value ) {
$this->data[$name] =& $value; $this->data[$name] =& $value;
} }
/** /**
* @param MediaWikiI18N $t * @param MediaWikiI18N &$t
*/ */
public function setTranslator( &$t ) { public function setTranslator( &$t ) {
$this->translator = &$t; $this->translator = &$t;

8
includes/skins/Skin.php
View file

@ -449,7 +449,7 @@ abstract class Skin extends ContextSource {
* "<body>" tag, skins can override it if they have a need to add in any * "<body>" tag, skins can override it if they have a need to add in any
* body attributes or classes of their own. * body attributes or classes of their own.
* @param OutputPage $out * @param OutputPage $out
* @param array $bodyAttrs * @param array &$bodyAttrs
*/ */
function addToBodyAttributes( $out, &$bodyAttrs ) { function addToBodyAttributes( $out, &$bodyAttrs ) {
// does nothing by default // does nothing by default
@ -1215,7 +1215,7 @@ abstract class Skin extends ContextSource {
/** /**
* make sure we have some title to operate on * make sure we have some title to operate on
* *
* @param Title $title * @param Title &$title
* @param string $name * @param string $name
*/ */
static function checkTitle( &$title, $name ) { static function checkTitle( &$title, $name ) {
@ -1286,7 +1286,7 @@ abstract class Skin extends ContextSource {
* *
* This is just a wrapper around addToSidebarPlain() for backwards compatibility * This is just a wrapper around addToSidebarPlain() for backwards compatibility
* *
* @param array $bar * @param array &$bar
* @param string $message * @param string $message
*/ */
public function addToSidebar( &$bar, $message ) { public function addToSidebar( &$bar, $message ) {
@ -1296,7 +1296,7 @@ abstract class Skin extends ContextSource {
/** /**
* Add content from plain text * Add content from plain text
* @since 1.17 * @since 1.17
* @param array $bar * @param array &$bar
* @param string $text * @param string $text
* @return array * @return array
*/ */

4
includes/specialpage/AuthManagerSpecialPage.php
View file

@ -45,7 +45,7 @@ abstract class AuthManagerSpecialPage extends SpecialPage {
* @param AuthenticationRequest[] $requests * @param AuthenticationRequest[] $requests
* @param array $fieldInfo Field information array (union of all * @param array $fieldInfo Field information array (union of all
* AuthenticationRequest::getFieldInfo() responses). * AuthenticationRequest::getFieldInfo() responses).
* @param array $formDescriptor HTMLForm descriptor. The special key 'weight' can be set to * @param array &$formDescriptor HTMLForm descriptor. The special key 'weight' can be set to
* change the order of the fields. * change the order of the fields.
* @param string $action Authentication type (one of the AuthManager::ACTION_* constants) * @param string $action Authentication type (one of the AuthManager::ACTION_* constants)
* @return bool * @return bool
@ -709,7 +709,7 @@ abstract class AuthManagerSpecialPage extends SpecialPage {
* Sort the fields of a form descriptor by their 'weight' property. (Fields with higher weight * Sort the fields of a form descriptor by their 'weight' property. (Fields with higher weight
* are shown closer to the bottom; weight defaults to 0. Negative weight is allowed.) * are shown closer to the bottom; weight defaults to 0. Negative weight is allowed.)
* Keep order if weights are equal. * Keep order if weights are equal.
* @param array $formDescriptor * @param array &$formDescriptor
* @return array * @return array
*/ */
protected static function sortFormDescriptorFields( array &$formDescriptor ) { protected static function sortFormDescriptorFields( array &$formDescriptor ) {

2
includes/specialpage/LoginSignupSpecialPage.php
View file

@ -1339,7 +1339,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage {
} }
/** /**
* @param array $formDescriptor * @param array &$formDescriptor
*/ */
protected function postProcessFormDescriptor( &$formDescriptor, $requests ) { protected function postProcessFormDescriptor( &$formDescriptor, $requests ) {
// Pre-fill username (if not creating an account, T46775). // Pre-fill username (if not creating an account, T46775).

4
includes/specialpage/SpecialPageFactory.php
View file

@ -501,8 +501,8 @@ class SpecialPageFactory {
* Returns a title object if the page is redirected, false if there was no such special * Returns a title object if the page is redirected, false if there was no such special
* page, and true if it was successful. * page, and true if it was successful.
* *
* @param Title $title * @param Title &$title
* @param IContextSource $context * @param IContextSource &$context
* @param bool $including Bool output is being captured for use in {{special:whatever}} * @param bool $including Bool output is being captured for use in {{special:whatever}}
* @param LinkRenderer|null $linkRenderer (since 1.28) * @param LinkRenderer|null $linkRenderer (since 1.28)
* *

2
includes/specials/SpecialBlock.php
View file

@ -233,7 +233,7 @@ class SpecialBlock extends FormSpecialPage {
/** /**
* If the user has already been blocked with similar settings, load that block * If the user has already been blocked with similar settings, load that block
* and change the defaults for the form fields to match the existing settings. * and change the defaults for the form fields to match the existing settings.
* @param array $fields HTMLForm descriptor array * @param array &$fields HTMLForm descriptor array
* @return bool Whether fields were altered (that is, whether the target is * @return bool Whether fields were altered (that is, whether the target is
* already blocked) * already blocked)
*/ */

2
includes/specials/SpecialRecentchanges.php
View file

@ -868,7 +868,7 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
/** /**
* Filter $rows by categories set in $opts * Filter $rows by categories set in $opts
* *
* @param ResultWrapper $rows Database rows * @param ResultWrapper &$rows Database rows
* @param FormOptions $opts * @param FormOptions $opts
*/ */
function filterByCategories( &$rows, FormOptions $opts ) { function filterByCategories( &$rows, FormOptions $opts ) {

2
includes/specials/SpecialSearch.php
View file

@ -555,7 +555,7 @@ class SpecialSearch extends SpecialPage {
* Extract "power search" namespace settings from the request object, * Extract "power search" namespace settings from the request object,
* returning a list of index numbers to search. * returning a list of index numbers to search.
* *
* @param WebRequest $request * @param WebRequest &$request
* @return array * @return array
*/ */
protected function powerSearch( &$request ) { protected function powerSearch( &$request ) {

4
includes/upload/UploadBase.php
View file

@ -155,7 +155,7 @@ abstract class UploadBase {
/** /**
* Create a form of UploadBase depending on wpSourceType and initializes it * Create a form of UploadBase depending on wpSourceType and initializes it
* *
* @param WebRequest $request * @param WebRequest &$request
* @param string|null $type * @param string|null $type
* @return null|UploadBase * @return null|UploadBase
*/ */
@ -241,7 +241,7 @@ abstract class UploadBase {
/** /**
* Initialize from a WebRequest. Override this in a subclass. * Initialize from a WebRequest. Override this in a subclass.
* *
* @param WebRequest $request * @param WebRequest &$request
*/ */
abstract public function initializeFromRequest( &$request ); abstract public function initializeFromRequest( &$request );

2
includes/upload/UploadFromFile.php
View file

@ -34,7 +34,7 @@ class UploadFromFile extends UploadBase {
protected $mUpload = null; protected $mUpload = null;
/** /**
* @param WebRequest $request * @param WebRequest &$request
*/ */
function initializeFromRequest( &$request ) { function initializeFromRequest( &$request ) {
$upload = $request->getUpload( 'wpUploadFile' ); $upload = $request->getUpload( 'wpUploadFile' );

2
includes/upload/UploadFromStash.php
View file

@ -113,7 +113,7 @@ class UploadFromStash extends UploadBase {
} }
/** /**
* @param WebRequest $request * @param WebRequest &$request
*/ */
public function initializeFromRequest( &$request ) { public function initializeFromRequest( &$request ) {
// sends wpSessionKey as a default when wpFileKey is missing // sends wpSessionKey as a default when wpFileKey is missing

2
includes/upload/UploadFromUrl.php
View file

@ -141,7 +141,7 @@ class UploadFromUrl extends UploadBase {
/** /**
* Entry point for SpecialUpload * Entry point for SpecialUpload
* @param WebRequest $request * @param WebRequest &$request
*/ */
public function initializeFromRequest( &$request ) { public function initializeFromRequest( &$request ) {
$desiredDestName = $request->getText( 'wpDestFile' ); $desiredDestName = $request->getText( 'wpDestFile' );

2
includes/user/User.php
View file

@ -3661,7 +3661,7 @@ class User implements IDBAccessObject {
* If e-notif e-mails are on, they will receive notification mails on * If e-notif e-mails are on, they will receive notification mails on
* the next change of the page if it's watched etc. * the next change of the page if it's watched etc.
* @note If the user doesn't have 'editmywatchlist', this will do nothing. * @note If the user doesn't have 'editmywatchlist', this will do nothing.
* @param Title $title Title of the article to look at * @param Title &$title Title of the article to look at
* @param int $oldid The revision id being viewed. If not given or 0, latest revision is assumed. * @param int $oldid The revision id being viewed. If not given or 0, latest revision is assumed.
*/ */
public function clearNotification( &$title, $oldid = 0 ) { public function clearNotification( &$title, $oldid = 0 ) {