Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove meaningless default action name

Browse source 
Before: Get the value of the action=... parameter. If it's undefined
return 'view'. Check if 'view' equals 'ajax'.

After: Get the value of the action=... parameter. If it's undefined
return null. Check if null equals 'ajax'.

Same for both places. The default value 'view' is never used.

Change-Id: I56656218cfb895bffe886919c67ebf3b79d91515
This commit is contained in:
Thiemo Mättig 2014-10-27 15:35:41 +01:00
parent 71486e1326
commit a9cd3f449e
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/MediaWiki.php
View file

@ -59,7 +59,7 @@ class MediaWiki {
$request = $this->context->getRequest();
$curid = $request->getInt( 'curid' );
$title = $request->getVal( 'title' );
$action = $request->getVal( 'action', 'view' );
$action = $request->getVal( 'action' );
if ( $request->getCheck( 'search' ) ) {
// Compatibility with old search URLs which didn't use Special:Search
@ -489,8 +489,7 @@ class MediaWiki {
$request = $this->context->getRequest();
// Send Ajax requests to the Ajax dispatcher.
if ( $this->config->get( 'UseAjax' ) && $request->getVal( 'action', 'view' ) == 'ajax' ) {
if ( $this->config->get( 'UseAjax' ) && $request->getVal( 'action' ) === 'ajax' ) {
// Set a dummy title, because $wgTitle == null might break things
$title = Title::makeTitle( NS_MAIN, 'AJAX' );
$this->context->setTitle( $title );