Deprecate SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook

Bug: T254431
Change-Id: I2ad144ac7aa5b0243f070b350b7dfc61ee466743

RELEASE-NOTES-1.35

@@ -1197,6 +1197,9 @@ because of Phabricator reports.
   use SidebarBeforeOutput hook. The toolbox data itself is available in a
   sidebar data array which you can get from any class that's extending
   QuickTemplate.
+* SkinTemplateBuildNavUrlsNav_urlsAfterPermalink hook has been deprecated.
+  Use SidebarBeforeOutput hook and get the revision id from the OutputPage
+  object.
 * …
 
 === Other changes in 1.35 ===

docs/hooks.txt

@@ -3169,8 +3169,9 @@ subPageSubtitle() will run.
 $skin: Skin object
 $out: OutputPage object
 
-'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink': After creating the "permanent
-link" tab.
+'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink': DEPRECATED since 1.35! Use
+SidebarBeforeOutput.
+After creating the "permanent link" tab.
 [&]$sktemplate: SkinTemplate object
 &$nav_urls: array of tabs
 &$revid: The revision id of the permanent link

includes/HookContainer/DeprecatedHooks.php

@@ -63,6 +63,7 @@ class DeprecatedHooks {
 		'RevisionInsertComplete' => [ 'deprecatedVersion' => '1.31' ],
 		'SecondaryDataUpdates' => [ 'deprecatedVersion' => '1.32', 'silent' => true ],
 		'SpecialMuteSubmit' => [ 'deprecatedVersion' => '1.35', 'silent' => true ],
+		'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink' => [ 'deprecatedVersion' => '1.35' ],
 		'SkinTemplatePreventOtherActiveTabs' => [ 'deprecatedVersion' => '1.35' ],
 		'SkinTemplateTabAction' => [ 'deprecatedVersion' => '1.35' ],
 		'TitleMoveComplete' => [ 'deprecatedVersion' => '1.35', 'silent' => true ],

includes/skins/Hook/SkinTemplateBuildNavUrlsNav_urlsAfterPermalinkHook.php

@@ -6,7 +6,7 @@ namespace MediaWiki\Hook;
 use SkinTemplate;
 
 /**
- * @stable for implementation
+ * @deprecated since 1.35. Use SidebarBeforeOutput hook
  * @ingroup Hooks
  */
 interface SkinTemplateBuildNavUrlsNav_urlsAfterPermalinkHook {