Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LinkFilterTests: Uncomment test cases that should pass on PHP 5.5

Browse source 
Change-Id: If62f964c3a8e0eaaab6e7193d426cc4ddaa47ade
This commit is contained in:
Bartosz Dziewoński 2016-02-17 20:30:22 +01:00
parent 8b38f3887f
commit ab44c1a6f4
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/phpunit/includes/LinkFilterTest.php
View file

@ -124,15 +124,12 @@ class LinkFilterTest extends MediaWikiLangTestCase {
[ 'git://', '*.github.com/', 'git://a.b.c.d.e.f.github.com/prwef/abc-def.git' ],
[ '', 'gopher://*.test.com/', 'gopher://gopher.test.com/0/v2/vstat' ],
[ 'telnet://', '*.test.com', 'telnet://shell.test.com/~home/' ],
// The following only work in PHP >= 5.3.7, due to a bug in parse_url which eats
// the path from the url (https://bugs.php.net/bug.php?id=54180)
// array( '', 'http://test.com', 'http://test.com/index?arg=1' ),
// array( 'http://', '*.test.com', 'http://www.test.com/index?arg=1' ),
// array( '' ,
// 'http://xx23124:__ffdfdef__@www.test.com:12345/dir' ,
// 'http://name:pass@www.test.com:12345/dir/dir/file.xyz.php#__se__?arg1=_&arg2[]=4rtg'
// ),
[ '', 'http://test.com', 'http://test.com/index?arg=1' ],
[ 'http://', '*.test.com', 'http://www.test.com/index?arg=1' ],
[ '' ,
'http://xx23124:__ffdfdef__@www.test.com:12345/dir' ,
'http://name:pass@www.test.com:12345/dir/dir/file.xyz.php#__se__?arg1=_&arg2[]=4rtg'
],
// Tests for false positives
[ 'http://', 'test.com', 'http://www.test.com', false ],
@ -163,9 +160,9 @@ class LinkFilterTest extends MediaWikiLangTestCase {
// These are false positives too and ideally shouldn't match, but that
// would require using regexes and RLIKE instead of LIKE
// array( null, 'http://*.test.com', 'http://www.test.com:80', false ),
// array( '', 'https://*.wikimedia.org/r/#/q/status:open,n,z',
// 'https://gerrit.wikimedia.org/XXX/r/#/q/status:open,n,z', false ),
// [ null, 'http://*.test.com', 'http://www.test.com:80', false ],
// [ '', 'https://*.wikimedia.org/r/#/q/status:open,n,z',
// 'https://gerrit.wikimedia.org/XXX/r/#/q/status:open,n,z', false ],
];
}