Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Hard deprecate access to WikiRevision::$fileIsTemp

Browse source 
The property has been deprecated since 1.29.

Change-Id: I04ab2fc7aac85f448ebef3bb5bc24aa5c617f233
This commit is contained in:
Matěj Suchánek 2022-07-05 20:52:04 +02:00
parent 07a9769501
commit af0bb1a9be
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.39
View file

@ -433,6 +433,8 @@ because of Phabricator reports.
emit deprecation warnings.
* Overriding or calling DifferenceEngine::getDiffBodyCacheKey(), deprecated in
1.31, now emits deprecation warnings.
* Access to previously public property WikiRevision::$fileIsTemp, deprecated in
1.29, now emits deprecation warnings.
* …
=== Other changes in 1.39 ===

7
includes/import/WikiRevision.php
View file

@ -38,6 +38,7 @@ use MediaWiki\Revision\SlotRecord;
* @ingroup SpecialPage
*/
class WikiRevision implements ImportableUploadRevision, ImportableOldRevision {
use DeprecationHelper;
/**
* @since 1.2
@ -190,11 +191,11 @@ class WikiRevision implements ImportableUploadRevision, ImportableOldRevision {
/**
* @since 1.18
* @deprecated since 1.29 use Wikirevision::isTempSrc()
* @deprecated since 1.29 use WikiRevision::isTempSrc()
* First written to in 43d5d3b682cc1733ad01a837d11af4a402d57e6a
* Actually introduced in 52cd34acf590e5be946b7885ffdc13a157c1c6cf
*/
public $fileIsTemp;
private $fileIsTemp;
/** @var bool */
private $mNoUpdates = false;
@ -212,6 +213,8 @@ class WikiRevision implements ImportableUploadRevision, ImportableOldRevision {
public function __construct( Config $config ) {
$this->config = $config;
$this->slots = new MutableRevisionSlots();
$this->deprecatePublicProperty( 'fileIsTemp', '1.29' );
}
/**