Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Deprecate the UserIsHidden hook

Browse source 
This was replaced by GetUserBlock in 7a5508573a.

Handlers in production were updated to use GetUserBlock in
Ibbcd3a239.

Bug: T228948
Change-Id: I3e6da73e595e2bd6a96600fe2a6dc68a54d06a2e
This commit is contained in:
Thalia 2019-09-09 16:57:17 +01:00
parent ca3083c61e
commit af24fc1a7a
3 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.34
View file

@ -530,6 +530,8 @@ because of Phabricator reports.
* Specifying both the class and factory parameters for * Specifying both the class and factory parameters for
ApiModuleManager::addModule is now deprecated. The ObjectFactory spec should ApiModuleManager::addModule is now deprecated. The ObjectFactory spec should
be used instead. be used instead.
* The UserIsHidden hook is deprecated. Use GetUserBlock instead, and add a
system block that hides the user.
=== Other changes in 1.34 === === Other changes in 1.34 ===
* … * …

4
docs/hooks.txt
View file

@ -3729,7 +3729,9 @@ $ip: User's IP address
false if a UserGetRights hook might remove the named right. false if a UserGetRights hook might remove the named right.
$right: The user right being checked $right: The user right being checked
'UserIsHidden': Check if the user's name should be hidden. See User::isHidden(). 'UserIsHidden': DEPRECATED since 1.34 - use GetUserBlock instead, and add a
system block that hides the user. Check if the user's name should be hidden.
See User::isHidden().
$user: User in question. $user: User in question.
&$hidden: Set true if the user's name should be hidden. &$hidden: Set true if the user's name should be hidden.

2
includes/user/User.php
View file

@ -2169,7 +2169,7 @@ class User implements IDBAccessObject, UserIdentity {
if ( !$this->mHideName ) { if ( !$this->mHideName ) {
// Reset for hook // Reset for hook
$this->mHideName = false; $this->mHideName = false;
Hooks::run( 'UserIsHidden', [ $this, &$this->mHideName ] ); Hooks::run( 'UserIsHidden', [ $this, &$this->mHideName ], '1.34' );
} }
return (bool)$this->mHideName; return (bool)$this->mHideName;
} }