Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

populateRevisionLength: Update for Multi-Content Revisions

Browse source 
Populate with the total size of the revision rather than just the
content in its main slot.

Remove internal uses of Revision objects, replacing with RevisionRecord.

Bug: T246284
Change-Id: I3ab06c73eb717e0cbc39c5e856d23f98cce435d0
This commit is contained in:
DannyS712 2020-04-27 22:29:43 +00:00
parent 72a97878f6
commit b2fe84c498
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
maintenance/populateRevisionLength.php
View file

@ -22,7 +22,6 @@
*/
use MediaWiki\MediaWikiServices;
use MediaWiki\Revision\RevisionRecord;
use Wikimedia\Rdbms\IDatabase;
require_once __DIR__ . '/Maintenance.php';
@ -154,27 +153,24 @@ class PopulateRevisionLength extends LoggedUpdateMaintenance {
protected function upgradeRow( $row, $table, $idCol, $prefix ) {
$dbw = $this->getDB( DB_MASTER );
$revFactory = MediaWikiServices::getInstance()->getRevisionFactory();
if ( $table === 'archive' ) {
$revRecord = MediaWikiServices::getInstance()
->getRevisionFactory()
->newRevisionFromArchiveRow( $row );
$rev = new Revision( $revRecord );
$revRecord = $revFactory->newRevisionFromArchiveRow( $row );
} else {
$rev = new Revision( $row );
$revRecord = $revFactory->newRevisionFromRow( $row );
}
$content = $rev->getContent( RevisionRecord::RAW );
if ( !$content ) {
if ( !$revRecord ) {
# This should not happen, but sometimes does (T22757)
$id = $row->$idCol;
$this->output( "Content of $table $id unavailable!\n" );
$this->output( "RevisionRecord of $table $id unavailable!\n" );
return false;
}
# Update the row...
$dbw->update( $table,
[ "{$prefix}_len" => $content->getSize() ],
[ "{$prefix}_len" => $revRecord->getSize() ],
[ $idCol => $row->$idCol ],
__METHOD__
);