Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop $j alias for $, deprecated since 1.23

Browse source 
Bug: T280944
Change-Id: Ifb41d35d0d08b3c0631040b2f52d856de51adc67
This commit is contained in:
James D. Forrester 2019-07-12 16:24:06 -07:00
parent ee0cee4e53
commit b4efcdf49a
3 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
RELEASE-NOTES-1.37
View file

@ -280,6 +280,8 @@ because of Phabricator reports.
the "es6-polyfills" module directly intead.
* The deprecated "mediawiki.legacy.protect" ResourceLoader module, deprecated
since 1.36, has been removed. Use "mediawiki.action.protect" instead.
* The JavaScript alias $j for references to jQuery, deprecated since 1.23, has
been removed. Use $ instead.
* The AuthenticationProvider interface and the SessionProvider class no longer
extend the PSR LoggerAwareInterface concept, so they can't be typehinted as
LoggerAwareInterface.

4
resources/src/mediawiki.base/mediawiki.base.js
View file

@ -766,10 +766,6 @@ mw.user = {
tokens: new mw.Map()
};
// Alias $j to jQuery for backwards compatibility
// @deprecated since 1.23 Use $ or jQuery instead
mw.log.deprecate( window, '$j', $, 'Use $ or jQuery instead.' );
// Process callbacks for modern browsers (Grade A) that require modules.
queue = window.RLQ;
// Replace temporary RLQ implementation from startup.js with the

5
tests/qunit/suites/resources/startup/mediawiki.test.js
View file

@ -36,11 +36,6 @@
assert.ok( window.$, '$ defined' );
assert.strictEqual( window.$, window.jQuery, '$ alias to jQuery' );
this.suppressWarnings();
assert.ok( window.$j, '$j defined' );
assert.strictEqual( window.$j, window.jQuery, '$j alias to jQuery' );
this.restoreWarnings();
// window.mw and window.mediaWiki are not deprecated, but for some reason
// PhantomJS is triggerring the accessors on all mw.* properties in this test,
// and with that lots of unrelated deprecation notices.