Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Followup to r70638: Clean up code, add prop to function args, add comment

Browse source
This commit is contained in:
X! 2010-08-08 14:55:08 +00:00
parent 29d6b582a1
commit b528bcdf89
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
includes/api/ApiQueryPageProps.php
View file

@ -72,7 +72,7 @@ class ApiQueryPageProps extends ApiQueryBase {
foreach ( $this->everything as $pageid => $title ) {
$pageInfo = $this->extractPageInfo( $pageid, $title );
$pageInfo = $this->extractPageInfo( $pageid, $title, $prop );
$fit = $result->addValue( array(
'query',
'pages'
@ -92,7 +92,7 @@ class ApiQueryPageProps extends ApiQueryBase {
* @param $title Title object
* @return array
*/
private function extractPageInfo( $pageid, $title ) {
private function extractPageInfo( $pageid, $title, $prop ) {
global $wgPageProps;
$pageInfo = array();
@ -121,7 +121,7 @@ class ApiQueryPageProps extends ApiQueryBase {
return $pageInfo;
}
public function getCacheMode( $params ) {
public function getCacheMode() {
return 'public';
}
@ -148,6 +148,9 @@ class ApiQueryPageProps extends ApiQueryBase {
'continue' => 'When more results are available, use this to continue',
);
//This mess of code first gets the length of the biggest propname, and adds two onto it to make
//the number of characters should be used before the dash. If the biggest propname is shorter than 12 characters,
//the number of characters before the dash become 14.
$maxLen = max( array_map( 'strlen', array_keys( $wgPageProps ) ) );
$matchLen = $maxLen + 2;
if( $maxLen < 12 ) {