Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Switch last few uses of while loops to foreach in phase3

Browse source
This commit is contained in:
Sam Reed 2010-10-31 23:08:38 +00:00
parent 871b4ac63a
commit b5c9c3ddd6
7 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Export.php
View file

@ -167,7 +167,7 @@ class WikiExporter {
WHERE page_id=rev_page AND $nothidden AND " . $cond ;
$result = $this->db->query( $sql, __METHOD__ );
$resultset = $this->db->resultObject( $result );
while( $row = $resultset->fetchObject() ) {
foreach ( $resultset as $row ) {
$this->author_list .= "<contributor>" .
"<username>" .
htmlentities( $row->rev_user_text ) .

2
includes/ImagePage.php
View file

@ -644,7 +644,7 @@ EOT
$sk = $wgUser->getSkin();
$count = 0;
$elements = array();
while ( $s = $res->fetchObject() ) {
foreach ( $res as $s ) {
$count++;
if ( $count <= $limit ) {
// We have not yet reached the extra one that tells us there is more to fetch

2
includes/specials/SpecialContributions.php
View file

@ -416,7 +416,7 @@ class SpecialContributions extends SpecialPage {
$feed->outHeader();
if( $pager->getNumRows() > 0 ) {
while( $row = $pager->mResult->fetchObject() ) {
foreach ( $pager->mResult as $row ) {
$feed->outItem( $this->feedItem( $row ) );
}
}

2
includes/specials/SpecialListusers.php
View file

@ -167,7 +167,7 @@ class UsersPager extends AlphabeticPager {
}
$this->mResult->rewind();
$batch = new LinkBatch;
while ( $row = $this->mResult->fetchObject() ) {
foreach ( $this->mResult as $row ) {
$batch->addObj( Title::makeTitleSafe( NS_USER, $row->user_name ) );
}
$batch->execute();

2
includes/specials/SpecialNewpages.php
View file

@ -366,7 +366,7 @@ class SpecialNewpages extends IncludableSpecialPage {
$feed->outHeader();
if( $pager->getNumRows() > 0 ) {
while( $row = $pager->mResult->fetchObject() ) {
foreach ( $pager->mResult->fetchObject() as $row ) {
$feed->outItem( $this->feedItem( $row ) );
}
}

2
includes/specials/SpecialUndelete.php
View file

@ -492,7 +492,7 @@ class PageArchive {
$revision = null;
$restored = 0;
while( $row = $ret->fetchObject() ) {
foreach ( $ret as $row ) {
// Check for key dupes due to shitty archive integrity.
if( $row->ar_rev_id ) {
$exists = $dbw->selectField( 'revision', '1', array('rev_id' => $row->ar_rev_id), __METHOD__ );

5
includes/specials/SpecialVersion.php
View file

@ -294,13 +294,14 @@ class SpecialVersion extends SpecialPage {
}
if ( $cnt = count( $tags = $wgParser->getTags() ) ) {
for ( $i = 0; $i < $cnt; ++$i )
for ( $i = 0; $i < $cnt; ++$i ) {
$tags[$i] = "&lt;{$tags[$i]}&gt;";
}
$out .= $this->openExtType( wfMsg( 'version-parser-extensiontags' ), 'parser-tags' );
$out .= '<tr><td colspan="4">' . $this->listToText( $tags ). "</td></tr>\n";
}
if( $cnt = count( $fhooks = $wgParser->getFunctionHooks() ) ) {
if( count( $fhooks = $wgParser->getFunctionHooks() ) ) {
$out .= $this->openExtType( wfMsg( 'version-parser-function-hooks' ), 'parser-function-hooks' );
$out .= '<tr><td colspan="4">' . $this->listToText( $fhooks ) . "</td></tr>\n";
}