Fix some JobQueue IDEA errors

Change-Id: I624f65ee1ca97c1acae9b54ca36d910eb4e42a70
This commit is contained in:
Aaron Schulz 2016-03-04 11:33:52 -08:00
parent b3ffeea139
commit b5d8f3aed1
2 changed files with 2 additions and 5 deletions

View file

@ -452,7 +452,6 @@ class JobQueueDB extends JobQueue {
* @see JobQueue::doAck()
* @param Job $job
* @throws MWException
* @return Job|bool
*/
protected function doAck( Job $job ) {
if ( !isset( $job->metadata['id'] ) ) {
@ -476,8 +475,6 @@ class JobQueueDB extends JobQueue {
} catch ( DBError $e ) {
$this->throwDBException( $e );
}
return true;
}
/**

View file

@ -49,7 +49,7 @@
class JobQueueFederated extends JobQueue {
/** @var HashRing */
protected $partitionRing;
/** @var array (partition name => JobQueue) reverse sorted by weight */
/** @var JobQueue[] (partition name => JobQueue) reverse sorted by weight */
protected $partitionQueues = [];
/** @var int Maximum number of partitions to try */
@ -311,7 +311,7 @@ class JobQueueFederated extends JobQueue {
throw new MWException( "The given job has no defined partition name." );
}
return $this->partitionQueues[$job->metadata['QueuePartition']]->ack( $job );
$this->partitionQueues[$job->metadata['QueuePartition']]->ack( $job );
}
protected function doIsRootJobOldDuplicate( Job $job ) {