Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

resourceloader: Don't call wfExpandUrl() on load.php urls

Browse source 
wfExpandUrl() should only be used if the url needs to be absolute
and/or needs to point to the canonical, internal or default wgServer
for the wiki.

For meta-data or API responses this can make sense, but for resources
loaded by the browser from the current page, there is no added value
in expanding these to the default domain.

This is causing problems in custom setups such as at Wikimedia,
with "zero" and "m" sub domains for which $wgServer points to the
canonical domain.

Bug: T106966
Bug: T112646
Change-Id: Ie25d3a8f69564319a1b29b5c5904f3d352924a31
This commit is contained in:
Timo Tijhof 2015-09-15 21:21:04 +01:00
parent 47dda77573
commit b5e69c4ef6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/resourceloader/ResourceLoader.php
View file

@ -1485,7 +1485,7 @@ MESSAGE;
$query = self::createLoaderQuery( $context, $extraQuery );
$script = $this->getLoadScript( $source );
return wfExpandUrl( wfAppendQuery( $script, $query ), PROTO_RELATIVE );
return wfAppendQuery( $script, $query );
}
/**
@ -1513,7 +1513,7 @@ MESSAGE;
$only, $printable, $handheld, $extraQuery
);
return wfExpandUrl( wfAppendQuery( $wgLoadScript, $query ), PROTO_RELATIVE );
return wfAppendQuery( $wgLoadScript, $query );
}
/**