Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

follow-up r74150 - empty() == bad.

Browse source
This commit is contained in:
Brian Wolff 2010-10-02 21:35:00 +00:00
parent f8efa1a751
commit b88d5a8f12
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
includes/Preferences.php
View file

@ -1107,7 +1107,8 @@ class Preferences {
$wgLang->formatNum( $wgMaxSigChars )
)
);
} elseif ( !empty( $alldata['fancysig'] ) &&
} elseif ( isset( $alldata['fancysig'] ) &&
$alldata['fancysig'] &&
false === $wgParser->validateSig( $signature ) ) {
return Xml::element( 'span', array( 'class' => 'error' ), wfMsg( 'badsig' ) );
} else {
@ -1117,7 +1118,7 @@ class Preferences {
static function cleanSignature( $signature, $alldata ) {
global $wgParser;
if ( !empty( $alldata['fancysig'] ) ) {
if ( isset( $alldata['fancysig'] ) && $alldata['fancysig'] ) {
$signature = $wgParser->cleanSig( $signature );
} else {
// When no fancy sig used, make sure ~{3,5} get removed.