Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

registration: Apply manifest v2 logic to hypothetical v3

Browse source 
If a new manifest version would be published, this could end in a
regression if the corresponding if statements are forgotten to be
updated. If there is no breaking change in some area, the code from
manifest_version 2 should still be used. Therefore it makes sense to set
these if statements for all versions greater than 2 as well, to prevent
that when a new version is released, the code of version 1 is used.

Change-Id: I0a9feda19cec5be07e6ad0f46fef8c3140f14eca
This commit is contained in:
Alexander Vorwerk 2021-09-04 21:04:03 +02:00 committed by Legoktm
parent b9397dad45
commit b88db33fe4
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/registration/ExtensionProcessor.php
View file

@ -219,7 +219,7 @@ class ExtensionProcessor implements Processor {
// config should be after all core globals are extracted,
// so duplicate setting detection will work fully
if ( $version === 2 ) {
if ( $version >= 2 ) {
$this->extractConfig2( $info, $dir );
} else {
// $version === 1
@ -233,7 +233,7 @@ class ExtensionProcessor implements Processor {
}
}
if ( $version === 2 ) {
if ( $version >= 2 ) {
$this->extractAttributes( $path, $info );
}
@ -248,7 +248,7 @@ class ExtensionProcessor implements Processor {
continue;
}
if ( $version === 2 ) {
if ( $version >= 2 ) {
// Only allowed attributes are set
if ( in_array( $key, self::CORE_ATTRIBS ) ) {
$this->storeToArray( $path, $key, $val, $this->attributes );