Merge "generatePhpCharToUpperMappings: avoid fetching service in loop"

This commit is contained in:
jenkins-bot 2022-12-21 08:02:02 +00:00 committed by Gerrit Code Review
commit bb95e89c23

View file

@ -60,13 +60,14 @@ class GeneratePhpCharToUpperMappings extends Maintenance {
$jsUpperChars = json_decode( $result->getStdout() );
'@phan-var string[] $jsUpperChars';
$contentLanguage = MediaWikiServices::getInstance()->getContentLanguage();
for ( $i = 0; $i <= 0x10ffff; $i++ ) {
if ( $i >= 0xd800 && $i <= 0xdfff ) {
// Skip surrogate pairs
continue;
}
$char = \UtfNormal\Utils::codepointToUtf8( $i );
$phpUpper = MediaWikiServices::getInstance()->getContentLanguage()->ucfirst( $char );
$phpUpper = $contentLanguage->ucfirst( $char );
$jsUpper = $jsUpperChars[$i];
if ( $jsUpper !== $phpUpper ) {
if ( $char === $phpUpper ) {