Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

logger: Make log() methods return void

Browse source 
psr/log 3.0.0 adds this return type.

For this specific case the fix is very simple, fully
compatible with the older version of psr/log, and
something we’ll have to do sooner or later anyway.

Bug: T356451
Change-Id: I49562ac7f1a71e82cab79fe44296feea573e26d4
(cherry picked from commit 9244d4b2623b9d789e7dea28e65b5ca6f9651aaf)
This commit is contained in:
Lucas Werkmeister 2025-01-28 13:06:48 +01:00 committed by Krinkle
parent 1d1c40cefd
commit bce2f8850d
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/debug/logger/ConsoleLogger.php
View file

@ -56,7 +56,7 @@ class ConsoleLogger extends AbstractLogger {
/**
* @inheritDoc
*/
public function log( $level, $message, array $context = [] ) {
public function log( $level, $message, array $context = [] ): void {
if ( !$this->minLevel || self::LEVELS[$level] >= self::LEVELS[$this->minLevel] ) {
fwrite( STDERR, "[$level] " .
LegacyLogger::format( $this->channel, $message, $context ) );

2
includes/debug/logger/LegacyLogger.php
View file

@ -156,7 +156,7 @@ class LegacyLogger extends AbstractLogger {
* @param string $message
* @param array $context
*/
public function log( $level, $message, array $context = [] ) {
public function log( $level, $message, array $context = [] ): void {
if ( is_string( $level ) ) {
$level = self::$levelMapping[$level];
}

2
includes/debug/logger/LogCapturingSpi.php
View file

@ -71,7 +71,7 @@ class LogCapturingSpi implements Spi {
$this->parent = $parent;
}
public function log( $level, $message, array $context = [] ) {
public function log( $level, $message, array $context = [] ): void {
$this->parent->capture( [
'channel' => $this->channel,
'level' => $level,

2
tests/phpunit/mocks/TestLogger.php
View file

@ -87,7 +87,7 @@ class TestLogger extends \Psr\Log\AbstractLogger {
$this->buffer = [];
}
public function log( $level, $message, array $context = [] ) {
public function log( $level, $message, array $context = [] ): void {
$message = trim( $message );
if ( $this->filter ) {