Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Throw a bit more helpful unknownerror at AS_END, indicating that AS_END was encountered. This actually needs fixing higher up, but this at least clarifies for now what kind of unknownerror occurred.

Browse source
This commit is contained in:
Bryan Tong Minh 2009-10-28 13:35:39 +00:00
parent 7357bd8bb9
commit be1cd24b80
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/api/ApiEditPage.php
View file

@ -268,10 +268,6 @@ class ApiEditPage extends ApiBase {
#case EditPage::AS_SUMMARY_NEEDED: Can't happen since we set wpIgnoreBlankSummary
case EditPage::AS_TEXTBOX_EMPTY:
$this->dieUsageMsg(array('emptynewsection'));
case EditPage::AS_END:
# This usually means some kind of race condition
# or DB weirdness occurred. Throw an unknown error here.
$this->dieUsageMsg(array('unknownerror'));
case EditPage::AS_SUCCESS_NEW_ARTICLE:
$r['new'] = '';
case EditPage::AS_SUCCESS_UPDATE:
@ -294,6 +290,14 @@ class ApiEditPage extends ApiBase {
$newArticle->getTimestamp());
}
break;
case EditPage::AS_END:
# This usually means some kind of race condition
# or DB weirdness occurred. Fall through to throw an unknown
# error.
# This needs fixing higher up, as Article::doEdit should be
# used rather than Article::updateArticle, so that specific
# error conditions can be returned
default:
$this->dieUsageMsg(array('unknownerror', $retval));
}