Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove dead code from RCCacheEntryFactory

Browse source 
Change-Id: I7832bac1e9c700e4a2a37b765d257ce8a7ace458
This commit is contained in:
Matěj Suchánek 2019-09-13 11:51:52 +02:00
parent 7d54426c37
commit bfd32fc842
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
includes/changes/RCCacheEntryFactory.php
View file

@ -56,7 +56,6 @@ class RCCacheEntryFactory {
*/
public function newFromRecentChange( RecentChange $baseRC, $watched ) {
$user = $this->context->getUser();
$counter = $baseRC->counter;
$cacheEntry = RCCacheEntry::newFromParent( $baseRC );
@ -73,8 +72,8 @@ class RCCacheEntryFactory {
// called too many times (50% of CPU time on RecentChanges!).
$showDiffLinks = $this->showDiffLinks( $cacheEntry, $user );
$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks, $counter );
$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks, $counter );
$cacheEntry->difflink = $this->buildDiffLink( $cacheEntry, $showDiffLinks );
$cacheEntry->curlink = $this->buildCurLink( $cacheEntry, $showDiffLinks );
$cacheEntry->lastlink = $this->buildLastLink( $cacheEntry, $showDiffLinks );
// Make user links
@ -182,11 +181,10 @@ class RCCacheEntryFactory {
/**
* @param RecentChange $cacheEntry
* @param bool $showDiffLinks
* @param int $counter
*
* @return string
*/
private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
private function buildCurLink( RecentChange $cacheEntry, $showDiffLinks ) {
$queryParams = $this->buildCurQueryParams( $cacheEntry );
$curMessage = $this->getMessage( 'cur' );
$logTypes = [ RC_LOG ];
@ -217,11 +215,10 @@ class RCCacheEntryFactory {
/**
* @param RecentChange $cacheEntry
* @param bool $showDiffLinks
* @param int $counter
*
* @return string
*/
private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks, $counter ) {
private function buildDiffLink( RecentChange $cacheEntry, $showDiffLinks ) {
$queryParams = $this->buildDiffQueryParams( $cacheEntry );
$diffMessage = $this->getMessage( 'diff' );
$logTypes = [ RC_NEW, RC_LOG ];