Remove or replace usages of "sane"
Bug: T254646 Change-Id: Ia660ab95353cd8f05c50e60f30d29fd22b018a43
This commit is contained in:
parent
325ae962e4
commit
c054b10423
10 changed files with 13 additions and 13 deletions
|
|
@ -761,10 +761,10 @@ class CategoryViewer extends ContextSource {
|
|||
*/
|
||||
private function getCountMessage( $rescnt, $dbcnt, $type ) {
|
||||
// There are three cases:
|
||||
// 1) The category table figure seems sane. It might be wrong, but
|
||||
// 1) The category table figure seems good. It might be wrong, but
|
||||
// we can't do anything about it if we don't recalculate it on ev-
|
||||
// ery category view.
|
||||
// 2) The category table figure isn't sane, like it's smaller than the
|
||||
// 2) The category table figure isn't good, like it's smaller than the
|
||||
// number of actual results, *but* the number of results is less
|
||||
// than $this->limit and there's no offset. In this case we still
|
||||
// know the right figure.
|
||||
|
|
@ -788,10 +788,10 @@ class CategoryViewer extends ContextSource {
|
|||
if ( $dbcnt == $rescnt ||
|
||||
( ( $rescnt == $this->limit || $fromOrUntil ) && $dbcnt > $rescnt )
|
||||
) {
|
||||
// Case 1: seems sane.
|
||||
// Case 1: seems good.
|
||||
$totalcnt = $dbcnt;
|
||||
} elseif ( $rescnt < $this->limit && !$fromOrUntil ) {
|
||||
// Case 2: not sane, but salvageable. Use the number of results.
|
||||
// Case 2: not good, but salvageable. Use the number of results.
|
||||
$totalcnt = $rescnt;
|
||||
} else {
|
||||
// Case 3: hopeless. Don't give a total count at all.
|
||||
|
|
|
|||
|
|
@ -202,7 +202,7 @@ class CommentParser {
|
|||
) {
|
||||
// @todo $append here is something of a hack to preserve the status
|
||||
// quo. Someone who knows more about bidi and such should decide
|
||||
// (1) what sane rendering even *is* for an LTR edit summary on an RTL
|
||||
// (1) what sensible rendering even *is* for an LTR edit summary on an RTL
|
||||
// wiki, both when autocomments exist and when they don't, and
|
||||
// (2) what markup will make that actually happen.
|
||||
$append = '';
|
||||
|
|
|
|||
|
|
@ -395,7 +395,7 @@ class ContentSecurityPolicy {
|
|||
*/
|
||||
private function getAdditionalSelfUrls() {
|
||||
// XXX on a foreign repo, the included description page can have anything on it,
|
||||
// including inline scripts. But nobody sane does that.
|
||||
// including inline scripts. But nobody does that.
|
||||
|
||||
// In principle, you can have even more complex configs... (e.g. The urlsByExt option)
|
||||
$pathUrls = [];
|
||||
|
|
|
|||
|
|
@ -4266,7 +4266,7 @@ class Language {
|
|||
*
|
||||
* @param string $text Text to be converted
|
||||
* @return string
|
||||
* @todo this should get integrated somewhere sane
|
||||
* @todo this should get integrated somewhere sensible
|
||||
*/
|
||||
public function convertHtml( $text ) {
|
||||
return htmlspecialchars( $this->convert( $text ) );
|
||||
|
|
|
|||
|
|
@ -1219,7 +1219,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware
|
|||
*/
|
||||
protected function getTempTableWrites( $sql, $pseudoPermanent ) {
|
||||
// Regexes for basic queries that can create/change/drop temporary tables.
|
||||
// For simplicity, this only looks for tables with sane, alphanumeric, names;
|
||||
// For simplicity, this only looks for tables with sensible, alphanumeric, names;
|
||||
// temporary tables only need simple programming names anyway.
|
||||
static $regexes = null;
|
||||
if ( $regexes === null ) {
|
||||
|
|
|
|||
|
|
@ -152,7 +152,7 @@ abstract class DatabaseMysqlBase extends Database {
|
|||
null,
|
||||
$tablePrefix
|
||||
);
|
||||
// Abstract over any insane MySQL defaults
|
||||
// Abstract over any excessive MySQL defaults
|
||||
$set = [ 'group_concat_max_len = 262144' ];
|
||||
// Set SQL mode, default is turning them all off, can be overridden or skipped with null
|
||||
if ( is_string( $this->sqlMode ) ) {
|
||||
|
|
|
|||
|
|
@ -143,7 +143,7 @@ class ActorStore implements UserIdentityLookup, ActorNormalization {
|
|||
*/
|
||||
public function newActorFromRowFields( $userId, $name, $actorId ): UserIdentity {
|
||||
// For backwards compatibility we are quite relaxed about what to accept,
|
||||
// but try not to create entirely insane objects. As we move more code
|
||||
// but try not to create entirely incorrect objects. As we move more code
|
||||
// from ActorMigration aliases to proper join with the actor table,
|
||||
// we should use ::newActorFromRow more, and eventually deprecate this method.
|
||||
$userId = $userId === null ? 0 : (int)$userId;
|
||||
|
|
|
|||
|
|
@ -470,7 +470,7 @@ class UppercaseTitlesForUnicodeTransition extends Maintenance {
|
|||
* are redirects to the same place, there's no point in keeping it.
|
||||
*
|
||||
* Note the caller will still rename it before deleting it, so the archive
|
||||
* and logging rows wind up in a sane place.
|
||||
* and logging rows wind up in a sensible place.
|
||||
*
|
||||
* @param IDatabase $db
|
||||
* @param Title $oldTitle
|
||||
|
|
|
|||
|
|
@ -351,7 +351,7 @@
|
|||
$( function () {
|
||||
var selector;
|
||||
|
||||
// Enable only live diff on user .js/.css pages, as there's no sane way of
|
||||
// Enable only live diff on user .js/.css pages, as there's no sensible way of
|
||||
// "previewing" the scripts or styles without reloading the page.
|
||||
if ( $( '#mw-userjsyoucanpreview, #mw-usercssyoucanpreview, #mw-userjspreview, #mw-usercsspreview' ).length ) {
|
||||
selector = '#wpDiff';
|
||||
|
|
|
|||
|
|
@ -329,7 +329,7 @@
|
|||
$( this ).trigger( 'keypress' );
|
||||
} )
|
||||
// In most skins (at least Monobook and Vector), the font-size is messed up in <body>.
|
||||
// (they use 2 elements to get a sane font-height). So, instead of making exceptions for
|
||||
// (they use 2 elements to get a sensible font-height). So, instead of making exceptions for
|
||||
// each skin or adding more stylesheets, just copy it from the active element so auto-fit.
|
||||
.each( function () {
|
||||
var $this = $( this );
|
||||
|
|
|
|||
Loading…
Reference in a new issue