Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DairikiDiff: Optimise method WordLevelDiff._split()

Browse source 
_split() copied two arrays N times, where N is number of lines in diff.
This was done by $a = array_merge($a, ...);
Instead of doing this, new words are appended to the end of array
using []= syntax.

Bug: 47989
Change-Id: I41338a2a82fbc20d7511f4c79581880febeeeea5
This commit is contained in:
Boris Nagaev 2013-05-02 18:33:15 +04:00 committed by Gerrit Code Review
parent a17a71b8e5
commit c3a13553fa
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/diff/DairikiDiff.php
View file

@ -1284,8 +1284,12 @@ class WordLevelDiff extends MappedDiff {
if ( preg_match_all( '/ ( [^\S\n]+ | [0-9_A-Za-z\x80-\xff]+ | . ) (?: (?!< \n) [^\S\n])? /xs',
$line, $m ) )
{
$words = array_merge( $words, $m[0] );
$stripped = array_merge( $stripped, $m[1] );
foreach ( $m[0] as $word ) {
$words[] = $word;
}
foreach ( $m[1] as $stripped_word ) {
$stripped[] = $stripped_word;
}
}
}
}