Add missing empty lines between methods

This might hint at an edge-case in the PHP CodeSniffer sniff that should
detect if methods are separated by a single empty line. Feel free to
investigate. I, personally, can't invest more time in this than
suggesting this quick fix.

Change-Id: Ib3c60eac76f255b4fe929f7933de256222716576
This commit is contained in:
Thiemo Kreuz 2019-01-15 16:04:58 +01:00 committed by Umherirrender
parent 918d9d8371
commit c3dfa88966
13 changed files with 18 additions and 0 deletions

View file

@ -846,6 +846,7 @@ class Revision implements IDBAccessObject {
$user = $this->mRecord->getUser( $audience, $user );
return $user ? $user->getName() : '';
}
/**
* Fetch revision comment if it's available to the specified audience.
* If the specified audience does not have access to the comment, an

View file

@ -85,6 +85,7 @@ class TextSlotDiffRenderer extends SlotDiffRenderer {
public function setLanguage( Language $language ) {
$this->language = $language;
}
/**
* @param int $cutoff
* @see $wgWikiDiff2MovedParagraphDetectionCutoff

View file

@ -18,6 +18,7 @@ class MWUnknownContentModelException extends MWException {
'handle this content model.' );
$this->modelId = $modelId;
}
/** @return string */
public function getModelId() {
return $this->modelId;

View file

@ -364,6 +364,7 @@ class XmlTypeCheck {
$this->filterMatchType = $callbackReturn;
}
}
/**
* Handle coming across a <!DOCTYPE declaration.
*

View file

@ -733,6 +733,7 @@ class ParserOptions {
public function getMagicPMIDLinks() {
return $this->getOption( 'magicPMIDLinks' );
}
/**
* Are magic RFC links enabled?
* @since 1.28

View file

@ -45,6 +45,7 @@ class InterwikiSearchResultSetWidget implements SearchResultSetWidget {
$this->output = $specialSearch->getOutput();
$this->showMultimedia = $showMultimedia;
}
/**
* @param string $term User provided search term
* @param SearchResultSet|SearchResultSet[] $resultSets List of interwiki

View file

@ -102,6 +102,7 @@ abstract class RevisionStoreDbTestBase extends MediaWikiTestCase {
$this->testPageTitle = Title::newFromText( 'UTPage-' . __CLASS__ );
return $this->testPageTitle;
}
/**
* @return WikiPage
*/

View file

@ -9,10 +9,12 @@ class WebPHandlerTest extends MediaWikiTestCase {
// Allocated file for testing
$this->tempFileName = tempnam( wfTempDir(), 'WEBP' );
}
public function tearDown() {
parent::tearDown();
unlink( $this->tempFileName );
}
/**
* @dataProvider provideTestExtractMetaData
*/
@ -22,6 +24,7 @@ class WebPHandlerTest extends MediaWikiTestCase {
$this->assertEquals( $expectedResult, WebPHandler::extractMetadata( $this->tempFileName ) );
}
public function provideTestExtractMetaData() {
// phpcs:disable Generic.Files.LineLength
return [
@ -80,6 +83,7 @@ class WebPHandlerTest extends MediaWikiTestCase {
public function testWithFileExtractMetaData( $filename, $expectedResult ) {
$this->assertEquals( $expectedResult, WebPHandler::extractMetadata( $filename ) );
}
public function provideTestWithFileExtractMetaData() {
return [
[ __DIR__ . '/../../data/media/2_webp_ll.webp',
@ -108,6 +112,7 @@ class WebPHandlerTest extends MediaWikiTestCase {
$handler = new WebPHandler();
$this->assertEquals( $expectedResult, $handler->getImageSize( null, $path ) );
}
public function provideTestGetImageSize() {
return [
// Public domain files from https://developers.google.com/speed/webp/gallery2
@ -130,6 +135,7 @@ class WebPHandlerTest extends MediaWikiTestCase {
$mime = MediaWiki\MediaWikiServices::getInstance()->getMimeAnalyzer();
$this->assertEquals( 'image/webp', $mime->guessMimeType( $path, false ) );
}
public function provideTestGetMimeType() {
return [
// Public domain files from https://developers.google.com/speed/webp/gallery2

View file

@ -118,6 +118,7 @@ class PoolWorkArticleViewTest extends MediaWikiTestCase {
}
];
}
/**
* @dataProvider provideMagicWords
*/

View file

@ -31,6 +31,7 @@ class ResourceLoaderLessVarFileModuleTest extends ResourceLoaderTestCase {
]
];
}
/**
* @dataProvider providerWrapAndEscapeMessage
* @covers ResourceLoaderLessVarFileModule::wrapAndEscapeMessage

View file

@ -499,6 +499,7 @@ mw.loader.register( [
] ]
];
}
/**
* @covers ResourceLoaderStartUpModule::getModuleRegistrations
* @dataProvider provideRegistrations

View file

@ -837,6 +837,7 @@ mw.example();
$response
);
}
/**
* Verify that when building the startup module response,
* an exception from one module class will not break the entire

View file

@ -84,6 +84,7 @@ class UploadStashTest extends MediaWikiTestCase {
] ) ],
];
}
/**
* @dataProvider provideValidRequests
*/