Merge "Enforce concealment of hidden RelevantUser at Skin level"

includes/OutputPage.php

@@ -3278,7 +3278,6 @@ class OutputPage extends ContextSource {
 		// Get the relevant title so that AJAX features can use the correct page name
 		// when making API requests from certain special pages (T36972).
 		$relevantTitle = $sk->getRelevantTitle();
-		$relevantUser = $sk->getRelevantUser();
 
 		if ( $ns === NS_SPECIAL ) {
 			list( $canonicalSpecialPageName, /*...*/ ) =
@@ -3379,11 +3378,9 @@ class OutputPage extends ContextSource {
 		if ( $title->isMainPage() ) {
 			$vars['wgIsMainPage'] = true;
 		}
-		if ( $relevantUser && ( !$relevantUser->isHidden() ||
-				$this->getAuthority()->isAllowed( 'hideuser' ) )
-		) {
-			// T120883 if the user is hidden and the viewer cannot see
-			// hidden users, pretend like it does not exist at all.
+
+		$relevantUser = $sk->getRelevantUser();
+		if ( $relevantUser ) {
 			$vars['wgRelevantUserName'] = $relevantUser->getName();
 		}
 		// End of stable config vars

includes/skins/Skin.php

@@ -52,6 +52,10 @@ abstract class Skin extends ContextSource {
 	 */
 	protected $options = [];
 	protected $mRelevantTitle = null;
+
+	/**
+	 * @var User|null
+	 */
 	protected $mRelevantUser = null;
 
 	/**
@@ -415,7 +419,7 @@ abstract class Skin extends ContextSource {
 	 * @see self::getRelevantUser()
 	 * @param User $u
 	 */
-	public function setRelevantUser( $u ) {
+	public function setRelevantUser( User $u ) {
 		$this->mRelevantUser = $u;
 	}
 
@@ -425,12 +429,11 @@ abstract class Skin extends ContextSource {
 	 * Special:Contributions mark the user which they are relevant to so that
 	 * things like the toolbox can display the information they usually are only
 	 * able to display on a user's userpage and talkpage.
-	 * @return User
+	 *
+	 * @return User|null Null if there's no relevant user or the viewer cannot view it.
 	 */
 	public function getRelevantUser() {
-		if ( isset( $this->mRelevantUser ) ) {
-			return $this->mRelevantUser;
-		}
+		if ( $this->mRelevantUser === null ) {
 			$title = $this->getRelevantTitle();
 			if ( $title->hasSubjectNamespace( NS_USER ) ) {
 				$rootUser = $title->getRootText();
@@ -441,17 +444,27 @@ abstract class Skin extends ContextSource {
 
 					if ( $user ) {
 						$user->load( User::READ_NORMAL );
+						$this->mRelevantUser = $user->isRegistered() ? $user : null;
+					}
+				}
+			}
+		}
 
-					if ( $user->isRegistered() ) {
-						$this->mRelevantUser = $user;
-					}
-				}
-			}
-			return $this->mRelevantUser;
-		}
+		$pm = MediaWikiServices::getInstance()->getPermissionManager();
+		// The relevant user should only be set if it exists. However, if it exists but is hidden,
+		// and the viewer cannot see hidden users, this exposes the fact that the user exists;
+		// pretend like the user does not exist in such cases, by setting it to null. T120883
+		if ( $this->mRelevantUser
+			&& $this->mRelevantUser->isRegistered()
+			&& $this->mRelevantUser->isHidden()
+			&& !$pm->userHasRight( $this->getUser(), 'hideuser' )
+		) {
 			return null;
 		}
 
+		return $this->mRelevantUser;
+	}
+
 	/**
 	 * Outputs the HTML generated by other functions.
 	 */

includes/specials/SpecialListFiles.php

@@ -123,7 +123,9 @@ class SpecialListFiles extends IncludableSpecialPage {
 			$out->addParserOutputContent( $pager->getBodyOutput() );
 		} else {
 			$user = $pager->getRelevantUser();
+			if ( $user ) {
 				$this->getSkin()->setRelevantUser( $user );
+			}
 			$pager->getForm();
 			$out->addParserOutputContent( $pager->getFullOutput() );
 		}

includes/specials/SpecialLog.php

@@ -256,8 +256,10 @@ class SpecialLog extends SpecialPage {
 		# Set relevant user
 		if ( $pager->getPerformer() ) {
 			$performerUser = User::newFromName( $pager->getPerformer(), false );
+			if ( $performerUser ) {
 				$this->getSkin()->setRelevantUser( $performerUser );
 			}
+		}
 
 		# Show form options
 		$loglist->showOptions(